[dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

[dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

[Hyong Youb Kim]

Hyong Youb Kim (2):
  net/enic: remove useless include
  net/enic: remove redundant log level check

 drivers/net/enic/enic_clsf.c   | 2 --
 drivers/net/enic/enic_ethdev.c | 9 ++++-----
 drivers/net/enic/enic_main.c   | 1 -
 3 files changed, 4 insertions(+), 8 deletions(-)

-- 
2.16.2

[dpdk-dev] [PATCH 1/2] net/enic: remove useless include

[Hyong Youb Kim]

libgen.h is not used, so do not include it.

Fixes: fefed3d1e62c ("enic: new driver")
Cc: stable@dpdk.org

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic_clsf.c | 2 --
 drivers/net/enic/enic_main.c | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index 9d95201ec..9e9e548c2 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -3,8 +3,6 @@
  * Copyright 2007 Nuova Systems, Inc.  All rights reserved.
  */
 
-#include <libgen.h>
-
 #include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
 #include <rte_hash.h>
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 621a984a0..2652949a2 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -8,7 +8,6 @@
 #include <sys/stat.h>
 #include <sys/mman.h>
 #include <fcntl.h>
-#include <libgen.h>
 
 #include <rte_pci.h>
 #include <rte_bus_pci.h>
-- 
2.16.2

[dpdk-dev] [PATCH 2/2] net/enic: remove redundant log level check

[Hyong Youb Kim]

Fixes: 8d496995346c ("net/enic: support multicast filtering")
Cc: stable@dpdk.org

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic_ethdev.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index fbbec2266..8d14d8ac7 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -647,11 +647,10 @@ static int enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev,
 static void debug_log_add_del_addr(struct ether_addr *addr, bool add)
 {
 	char mac_str[ETHER_ADDR_FMT_SIZE];
-	if (rte_log_get_level(enicpmd_logtype_init) == RTE_LOG_DEBUG) {
-		ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr);
-		PMD_INIT_LOG(ERR, " %s address %s\n",
-			     add ? "add" : "remove", mac_str);
-	}
+
+	ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr);
+	PMD_INIT_LOG(DEBUG, " %s address %s\n",
+		     add ? "add" : "remove", mac_str);
 }
 
 static int enicpmd_set_mc_addr_list(struct rte_eth_dev *eth_dev,
-- 
2.16.2

Re: [dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

[Ferruh Yigit]

On 1/14/2019 3:01 PM, Hyong Youb Kim wrote:
> Hyong Youb Kim (2):
>   net/enic: remove useless include
>   net/enic: remove redundant log level check

Series applied to dpdk-next-net/master, thanks.