DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hyong Youb Kim <hyonkim@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] net/enic: remove redundant log level check
Date: Mon, 14 Jan 2019 07:01:22 -0800	[thread overview]
Message-ID: <20190114150122.16999-3-hyonkim@cisco.com> (raw)
In-Reply-To: <20190114150122.16999-1-hyonkim@cisco.com>

Fixes: 8d496995346c ("net/enic: support multicast filtering")
Cc: stable@dpdk.org

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
 drivers/net/enic/enic_ethdev.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index fbbec2266..8d14d8ac7 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -647,11 +647,10 @@ static int enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev,
 static void debug_log_add_del_addr(struct ether_addr *addr, bool add)
 {
 	char mac_str[ETHER_ADDR_FMT_SIZE];
-	if (rte_log_get_level(enicpmd_logtype_init) == RTE_LOG_DEBUG) {
-		ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr);
-		PMD_INIT_LOG(ERR, " %s address %s\n",
-			     add ? "add" : "remove", mac_str);
-	}
+
+	ether_format_addr(mac_str, ETHER_ADDR_FMT_SIZE, addr);
+	PMD_INIT_LOG(DEBUG, " %s address %s\n",
+		     add ? "add" : "remove", mac_str);
 }
 
 static int enicpmd_set_mc_addr_list(struct rte_eth_dev *eth_dev,
-- 
2.16.2

  parent reply	other threads:[~2019-01-14 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 15:01 [dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes Hyong Youb Kim
2019-01-14 15:01 ` [dpdk-dev] [PATCH 1/2] net/enic: remove useless include Hyong Youb Kim
2019-01-14 15:01 ` Hyong Youb Kim [this message]
2019-01-14 16:41 ` [dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114150122.16999-3-hyonkim@cisco.com \
    --to=hyonkim@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=johndale@cisco.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).