From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, thomas@monjalon.net,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks
Date: Mon, 14 Jan 2019 17:00:28 -0800 [thread overview]
Message-ID: <20190114170028.68bdd4d7@hermes.lan> (raw)
In-Reply-To: <1547132768-2384-1-git-send-email-jiayu.hu@intel.com>
On Thu, 10 Jan 2019 23:06:08 +0800
Jiayu Hu <jiayu.hu@intel.com> wrote:
> +
> +#define ILLEGAL_ETHER_HDRLEN(len) ((len) != ETHER_HDR_LEN)
> +#define ILLEGAL_ETHER_VXLAN_HDRLEN(len) \
> + ((len) != (ETHER_VXLAN_HLEN + ETHER_HDR_LEN))
> +#define ILLEGAL_IPV4_HDRLEN(len) ((len) != sizeof(struct ipv4_hdr))
> +#define ILLEGAL_TCP_HDRLEN(len) \
> + (((len) < sizeof(struct tcp_hdr)) || ((len) > TCP_MAX_HLEN))
> +
Why not inline (which keeps type checking) instead of macro.
Results in same code.
Also, prefer "invalid" instead "ILLEGAL" . There is no government inforcing
a rule on packet headers.
Also, what about ipv4 options, or TCP options?
And even VXLAN header check should be more rigorous. What about not allowing
fragments in IP header for example.
If you are going to do enforcement, be as strict as you can.
next prev parent reply other threads:[~2019-01-15 1:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 1:57 [dpdk-dev] [PATCH] gro: fix overflow of TCP Options length calculation Jiayu Hu
2019-01-07 14:29 ` Bruce Richardson
2019-01-08 1:22 ` Hu, Jiayu
2019-01-08 6:19 ` Stephen Hemminger
2019-01-08 6:08 ` [dpdk-dev] [PATCH] gro: add missing invalid packet checks Jiayu Hu
2019-01-08 6:31 ` Stephen Hemminger
2019-01-08 8:14 ` Hu, Jiayu
2019-01-08 10:39 ` Ananyev, Konstantin
2019-01-08 11:33 ` Morten Brørup
2019-01-08 13:40 ` Hu, Jiayu
2019-01-08 13:43 ` Ananyev, Konstantin
2019-01-08 14:50 ` Morten Brørup
2019-01-09 3:32 ` Hu, Jiayu
2019-01-10 15:06 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2019-01-14 22:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-01-15 1:00 ` Stephen Hemminger [this message]
2019-01-15 2:48 ` [dpdk-dev] " Hu, Jiayu
2019-01-15 5:05 ` Wang, Yinan
2019-01-15 10:11 ` Ananyev, Konstantin
2019-01-15 12:18 ` Hu, Jiayu
2019-01-15 13:38 ` Hu, Jiayu
2019-01-16 0:45 ` [dpdk-dev] [PATCH v3] gro: add missing invalid TCP header length check Jiayu Hu
2019-01-16 9:49 ` Ananyev, Konstantin
2019-01-17 21:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114170028.68bdd4d7@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).