DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function
@ 2019-01-11  8:05 Xiaolong Ye
  2019-01-11 13:31 ` Tiwei Bie
  2019-01-15  6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
  0 siblings, 2 replies; 6+ messages in thread
From: Xiaolong Ye @ 2019-01-11  8:05 UTC (permalink / raw)
  To: dev, Maxime Coquelin, Tiwei Bie; +Cc: xiao.w.wang, Xiaolong Ye, stable

vhost_user_host_notifier_ctrl is not existed anymore, its statement in
header file should be removed accordingly.

Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
Cc: xiao.w.wang@intel.com
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index dc97be843..2a650fe4b 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function
  2019-01-11  8:05 [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function Xiaolong Ye
@ 2019-01-11 13:31 ` Tiwei Bie
  2019-01-12  1:01   ` Ye Xiaolong
  2019-01-15  6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
  1 sibling, 1 reply; 6+ messages in thread
From: Tiwei Bie @ 2019-01-11 13:31 UTC (permalink / raw)
  To: Xiaolong Ye; +Cc: dev, Maxime Coquelin, xiao.w.wang, stable

> vhost_user: remove statement for non-existed function

s/vhost_user/vhost/

On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
> header file should be removed accordingly.
> 
> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
> Cc: xiao.w.wang@intel.com
> Cc: stable@dpdk.org

There is no need to cc stable, because above commit is part
of 19.02 which hasn't been released yet.

For the rest,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  lib/librte_vhost/vhost_user.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> index dc97be843..2a650fe4b 100644
> --- a/lib/librte_vhost/vhost_user.h
> +++ b/lib/librte_vhost/vhost_user.h
> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>  /* vhost_user.c */
>  int vhost_user_msg_handler(int vid, int fd);
>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>  
>  /* socket.c */
>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function
  2019-01-11 13:31 ` Tiwei Bie
@ 2019-01-12  1:01   ` Ye Xiaolong
  0 siblings, 0 replies; 6+ messages in thread
From: Ye Xiaolong @ 2019-01-12  1:01 UTC (permalink / raw)
  To: Tiwei Bie; +Cc: dev, Maxime Coquelin, xiao.w.wang, stable

On 01/11, Tiwei Bie wrote:
>> vhost_user: remove statement for non-existed function
>
>s/vhost_user/vhost/
>
>On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
>> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
>> header file should be removed accordingly.
>> 
>> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
>> Cc: xiao.w.wang@intel.com
>> Cc: stable@dpdk.org
>
>There is no need to cc stable, because above commit is part
>of 19.02 which hasn't been released yet.
>
>For the rest,
>Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?

Thanks,
Xiaolong

>
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  lib/librte_vhost/vhost_user.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
>> index dc97be843..2a650fe4b 100644
>> --- a/lib/librte_vhost/vhost_user.h
>> +++ b/lib/librte_vhost/vhost_user.h
>> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>>  /* vhost_user.c */
>>  int vhost_user_msg_handler(int vid, int fd);
>>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
>> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>>  
>>  /* socket.c */
>>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> -- 
>> 2.17.1
>> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] vhost: remove statement for non-existed function
  2019-01-11  8:05 [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function Xiaolong Ye
  2019-01-11 13:31 ` Tiwei Bie
@ 2019-01-15  6:48 ` Xiaolong Ye
  2019-01-15  6:49   ` Tiwei Bie
  2019-01-17 11:33   ` Maxime Coquelin
  1 sibling, 2 replies; 6+ messages in thread
From: Xiaolong Ye @ 2019-01-15  6:48 UTC (permalink / raw)
  To: dev, Maxime Coquelin, Tiwei Bie; +Cc: xiao.w.wang, Xiaolong Ye

vhost_user_host_notifier_ctrl is not existed anymore, its statement in
header file should be removed accordingly.

Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
Cc: xiao.w.wang@intel.com

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index dc97be843..2a650fe4b 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
-- 
2.17.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] vhost: remove statement for non-existed function
  2019-01-15  6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
@ 2019-01-15  6:49   ` Tiwei Bie
  2019-01-17 11:33   ` Maxime Coquelin
  1 sibling, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2019-01-15  6:49 UTC (permalink / raw)
  To: Xiaolong Ye; +Cc: dev, Maxime Coquelin, xiao.w.wang

On Tue, Jan 15, 2019 at 02:48:13PM +0800, Xiaolong Ye wrote:
> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
> header file should be removed accordingly.
> 
> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
> Cc: xiao.w.wang@intel.com
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  lib/librte_vhost/vhost_user.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> index dc97be843..2a650fe4b 100644
> --- a/lib/librte_vhost/vhost_user.h
> +++ b/lib/librte_vhost/vhost_user.h
> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>  /* vhost_user.c */
>  int vhost_user_msg_handler(int vid, int fd);
>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>  
>  /* socket.c */
>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
> -- 
> 2.17.1

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] vhost: remove statement for non-existed function
  2019-01-15  6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
  2019-01-15  6:49   ` Tiwei Bie
@ 2019-01-17 11:33   ` Maxime Coquelin
  1 sibling, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2019-01-17 11:33 UTC (permalink / raw)
  To: Xiaolong Ye, dev, Tiwei Bie; +Cc: xiao.w.wang



On 1/15/19 7:48 AM, Xiaolong Ye wrote:
> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
> header file should be removed accordingly.
> 
> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
> Cc: xiao.w.wang@intel.com
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>   lib/librte_vhost/vhost_user.h | 1 -
>   1 file changed, 1 deletion(-)



Applied to dpdk-next-virtio/master.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-01-17 11:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11  8:05 [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function Xiaolong Ye
2019-01-11 13:31 ` Tiwei Bie
2019-01-12  1:01   ` Ye Xiaolong
2019-01-15  6:48 ` [dpdk-dev] [PATCH v2] vhost: " Xiaolong Ye
2019-01-15  6:49   ` Tiwei Bie
2019-01-17 11:33   ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).