From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds
Date: Tue, 15 Jan 2019 10:39:31 +0000 [thread overview]
Message-ID: <20190115103930.GA120024@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1848846.EbtBiuWXsB@xps>
On Mon, Jan 14, 2019 at 08:04:00PM +0100, Thomas Monjalon wrote:
> 14/01/2019 19:12, Alejandro Lucero:
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> > config/defconfig_i686-native-linuxapp-gcc | 5 +++++
> > config/defconfig_i686-native-linuxapp-icc | 5 +++++
> > config/defconfig_x86_x32-native-linuxapp-gcc | 5 +++++
> > 3 files changed, 15 insertions(+)
>
> You forgot config/defconfig_arm-armv7a-linuxapp-gcc.
>
> Applied with change for armv7, thanks
>
> PS: It makes me think we have no way to disable some PMDs
> for 32-bit with meson. Bruce, any idea?
>
Put something similar to below in the meson.build file for the driver:
if not dpdk_conf.has('RTE_ARCH_64')
build = false
endif
For drivers which don't already have a condition check you can simplify to:
build = (dpdk_conf.has('RTE_ARCH_64'))
/Bruce
prev parent reply other threads:[~2019-01-15 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 18:12 Alejandro Lucero
2019-01-14 19:04 ` Thomas Monjalon
2019-01-15 10:39 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115103930.GA120024@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).