From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DDC9F5F51 for ; Tue, 15 Jan 2019 11:39:35 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 02:39:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="106717744" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga007.jf.intel.com with SMTP; 15 Jan 2019 02:39:32 -0800 Received: by (sSMTP sendmail emulation); Tue, 15 Jan 2019 10:39:31 +0000 Date: Tue, 15 Jan 2019 10:39:31 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Alejandro Lucero , dev@dpdk.org Message-ID: <20190115103930.GA120024@bricha3-MOBL.ger.corp.intel.com> References: <20190114181254.27089-1-alejandro.lucero@netronome.com> <1848846.EbtBiuWXsB@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1848846.EbtBiuWXsB@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:39:36 -0000 On Mon, Jan 14, 2019 at 08:04:00PM +0100, Thomas Monjalon wrote: > 14/01/2019 19:12, Alejandro Lucero: > > Signed-off-by: Alejandro Lucero > > --- > > config/defconfig_i686-native-linuxapp-gcc | 5 +++++ > > config/defconfig_i686-native-linuxapp-icc | 5 +++++ > > config/defconfig_x86_x32-native-linuxapp-gcc | 5 +++++ > > 3 files changed, 15 insertions(+) > > You forgot config/defconfig_arm-armv7a-linuxapp-gcc. > > Applied with change for armv7, thanks > > PS: It makes me think we have no way to disable some PMDs > for 32-bit with meson. Bruce, any idea? > Put something similar to below in the meson.build file for the driver: if not dpdk_conf.has('RTE_ARCH_64') build = false endif For drivers which don't already have a condition check you can simplify to: build = (dpdk_conf.has('RTE_ARCH_64')) /Bruce