From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 98765137D for ; Tue, 15 Jan 2019 23:37:08 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id c123so2015530pfb.0 for ; Tue, 15 Jan 2019 14:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PTdPchYK+V6cuAY113Z84O7C9t8PHIFi3a1y1BeY56M=; b=w2pv1ESQdcRmm3lMH9wQ08RUCPPCzXMdxxcDv9OugWMgeVN/4rUXbLDDglTIYANAJ4 5Km23dO98+iRlHDGCRQhneS40LiwevFr5ZU+vlFnPE/XY0YV7uMGWELgV6/dwDGE7luB zsfI1xoAR8GknRYrhBCQ2h7VoArWkeVpNTFOs0OEDqE6/iFvpbHWvelxAiVPQcg15EUO oC/2IwD3mELEhu10+6tZeLuk6hnl5JD0ewYzUT9TJjR8Z3NlaOqSPlgSYIjxqEKCShNa M4tL3J5yCvrn5NZU3rMW52vuzAx6rXTD1BfbVtWGkjsTrFWFECUL8TExTv+0dgN90PqH OKvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PTdPchYK+V6cuAY113Z84O7C9t8PHIFi3a1y1BeY56M=; b=KkLx3qaZPsQRM6dMvV/pJE0Trw28cydm3QWf8D1YCwR6lvv32kBjZS5WpPF6ulrjsm 0XEPXWATMVve75jzVrXEpM6xHPnEUt/hf7s3jlYlltoPlZZTEpScXX4PpxpdAjRkZm7N Wmnno7atsMfXXYFaavZGnxfcMIrHRO12vSCx7w1+2092C5qj5ZSX2PJH2T8gAB2oBC2Z 9Cd28AFc53WwW2+1EePj4A6oW2qbpL9PcTN4bFY91+dMQGhUUCH6aMAuNiAgQ1WyAih0 gpOfkLagFenHU4Ijie4HiYnqhhK2SbHVrNs2A13EheDu83/Y+y/pOhHfGwC4Tmy6RPPl qyVw== X-Gm-Message-State: AJcUukd25249Ym3NizPKml6p+s7Nl+p39TVvAd1WQTCYUuykzXN7YScB zFGv3inE2SbMIPKXktVZRYQitg== X-Google-Smtp-Source: ALg8bN4nKY5fx8dR2rzu+QB3YFeXAUOKk2Eg9Rs6bpSqyUBg/7p8BNDHPuootLwiHNN6MxHGQDCHUg== X-Received: by 2002:a63:6bc1:: with SMTP id g184mr5991009pgc.25.1547591827600; Tue, 15 Jan 2019 14:37:07 -0800 (PST) Received: from shemminger-XPS-13-9360 ([167.220.61.105]) by smtp.gmail.com with ESMTPSA id 184sm5648243pfe.106.2019.01.15.14.37.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 14:37:07 -0800 (PST) Date: Tue, 15 Jan 2019 14:37:05 -0800 From: Stephen Hemminger To: Reshma Pattan Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, olivier.matz@6wind.com, thomas@monjalon.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, konstantin.ananyev@intel.com Message-ID: <20190115143705.08764641@shemminger-XPS-13-9360> In-Reply-To: <20181220121609.16314-2-reshma.pattan@intel.com> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 22:37:08 -0000 On Thu, 20 Dec 2018 12:16:09 +0000 Reshma Pattan wrote: > This patch implements the changes proposed in the deprecation > notes [1][2]. > > librte_mbuf changes: > The mbuf->hash.sched field is updated to support generic > definition in line with the ethdev traffic manager and meter APIs. > The new generic format contains: queue ID, traffic class, color. > > Added public APIs to set and get these new fields to and from mbuf. > > librte_sched changes: > In addtion, following API functions of the sched library have > been modified with an additional parameter of type struct > rte_sched_port to accommodate the changes made to mbuf sched field. > (i)rte_sched_port_pkt_write() > (ii) rte_sched_port_pkt_read_tree_path() > > librte_pipeline, qos_sched UT, qos_sched app are updated > to make use of new changes. > > Also mbuf->hash.txadapter has been added for eventdev txq, > rte_event_eth_tx_adapter_txq_set and rte_event_eth_tx_adapter_txq_get() > are updated to use mbuf->hash.txadapter.txq. > > doc: > Release notes updated. > Removed deprecation notice for mbuf->hash.sched and sched API. > > [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html > [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html > > Signed-off-by: Jasvinder Singh > Signed-off-by: Reshma Pattan > Acked-by: Cristian Dumitrescu > Acked-by: Konstantin Ananyev This patch breaks build of VPP because it refers to sched.hi and sched.lo. Breaking source compatibility is as bad (if not worse) than ABI breakage. Maybe make the sched field a union?