From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1E9BBDE0 for ; Wed, 16 Jan 2019 00:11:54 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id b5so2016626plr.4 for ; Tue, 15 Jan 2019 15:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZMFfTBKSVJOfu8HBQU0JvTIZLRWjPultS9faMTVWiYs=; b=tv791tP54GzRMlg1jYnqkehXdXTfpnFQZJ8xLSISXMl7H4usop4v6Nt+PwJCWbvbtu IAzdqclsX7TxnzYZIFFFD545W9x63RKjEdcLApM282XmhjPreE49fKjtUH/hclndBj32 kAPUPhuDSpYnMQCbuRgSNIeYV3oh0lrqbxcES1MZoSr+N4HBOD3FI6w3HUKJrYmmm7XV l+Ngwefx3owTU3AoR4Lg09el6hLyYYy/PX9qC+QPTfCFuJArg5hbDjrePlHKtkOp0oWm JXZq7xyktpw75HuHto2Xgg8TI8OYYLz2kK+lnr95Eezusho7f4ZzmtlQMRzyDgI0lPdz X3VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZMFfTBKSVJOfu8HBQU0JvTIZLRWjPultS9faMTVWiYs=; b=lQ6nPaOAKTJezDN1aE+lTV93d7SJdWRbxJOMx83ftukVcuEIdjLjZAkXvCkeo8etwL N8gZVqdp8tL51+WKPok8TTi3FFrfv2/Q1fR2sSiWaB5vZjewaIi+Feov5TObq+VUsxCG CM+/3WR+iCyxGXclmsdN6mrgBYAgRiKHbcrqhst79oaBHnpjkuuSHlTwbHA2qparSTCv iufrpOuWVC72c0qv2BweUu0XUAWgFfnUBElPh5QpAmmHqZ+zDaBmf5jLdHBtWV50RGfO rBNOsY9foXKLdN33SKdVOFE+1MAFjTI/5dywi4pS0Lb2Y7tqh0l+KCcCGqOFdYKYdggq s6rQ== X-Gm-Message-State: AJcUuke6KWKDRwUQ30BHddaiISuRIPf42viHm2Yt1+M7t/dQZNP7NABp mK5fXebJm7FoBn4uOl443kaRJA== X-Google-Smtp-Source: ALg8bN4KXehxzg7tpHRCQRE0hFmskDsKow50MBAAUERM9zOOYqr/EkuaYnfNFqeDF9xvL0126RPBXA== X-Received: by 2002:a17:902:12b:: with SMTP id 40mr6547595plb.72.1547593913801; Tue, 15 Jan 2019 15:11:53 -0800 (PST) Received: from shemminger-XPS-13-9360 ([167.220.98.105]) by smtp.gmail.com with ESMTPSA id 5sm5518286pfz.149.2019.01.15.15.11.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 15:11:53 -0800 (PST) Date: Tue, 15 Jan 2019 15:11:51 -0800 From: Stephen Hemminger To: Reshma Pattan Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, olivier.matz@6wind.com, thomas@monjalon.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, konstantin.ananyev@intel.com Message-ID: <20190115151151.5105b80e@shemminger-XPS-13-9360> In-Reply-To: <20181220121609.16314-2-reshma.pattan@intel.com> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 23:11:55 -0000 On Thu, 20 Dec 2018 12:16:09 +0000 Reshma Pattan wrote: > void > -rte_sched_port_pkt_write(struct rte_mbuf *pkt, > - uint32_t subport, uint32_t pipe, uint32_t traffic_class, > +rte_sched_port_pkt_write(struct rte_sched_port *port, > + struct rte_mbuf *pkt, > + uint32_t subport, uint32_t pipe, > + uint32_t traffic_class, > uint32_t queue, enum rte_meter_color color) Sorry I didn't notice this earlier, but changing the function signature like this is a complete ABI breakage. Old code will be passing different arguments than new code; therefore this change breaks both source and binary compatibility. Is 19.02 supposed to be an ABI/API breaking release? Or only an incremental update.