From: Stephen Hemminger <stephen@networkplumber.org>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment
Date: Tue, 15 Jan 2019 17:38:22 -0800 [thread overview]
Message-ID: <20190115173822.25a4a979@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190116003452.37403-1-xiaolong.ye@intel.com>
On Wed, 16 Jan 2019 08:34:52 +0800
Xiaolong Ye <xiaolong.ye@intel.com> wrote:
> The comment for igbuio_pci_irqhandler is out of date as the code evolves,
> remove it to avoid misleading.
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> kernel/linux/igb_uio/igb_uio.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
> index 3cf394bdf..d6ac51e79 100644
> --- a/kernel/linux/igb_uio/igb_uio.c
> +++ b/kernel/linux/igb_uio/igb_uio.c
> @@ -185,10 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
> return 0;
> }
>
> -/**
> - * This is interrupt handler which will check if the interrupt is for the right device.
> - * If yes, disable it here and will be enable later.
> - */
> static irqreturn_t
> igbuio_pci_irqhandler(int irq, void *dev_id)
> {
The comment is partially correct; if you look at the legacy case.
Maybe better to move the comment to pci_check_and_mask_intx in compat.h?
I see there is another incorrect comment there.
next prev parent reply other threads:[~2019-01-16 1:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:46 [dpdk-dev] [PATCH] " Xiaolong Ye
2019-01-15 16:08 ` Burakov, Anatoly
2019-01-15 23:54 ` Ye Xiaolong
2019-01-16 0:34 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-01-16 1:38 ` Stephen Hemminger [this message]
2019-01-16 5:17 ` Ye Xiaolong
2019-01-16 7:48 ` Ye Xiaolong
2019-01-16 18:55 ` Stephen Hemminger
2019-01-17 2:13 ` Ye Xiaolong
2019-01-22 1:52 ` Ye Xiaolong
2019-01-29 12:49 ` Ferruh Yigit
2019-01-31 8:13 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115173822.25a4a979@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).