From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E68FA29AC for ; Wed, 16 Jan 2019 00:54:23 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 15:54:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,483,1539673200"; d="scan'208";a="136120364" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga004.fm.intel.com with ESMTP; 15 Jan 2019 15:54:21 -0800 Date: Wed, 16 Jan 2019 07:54:23 +0800 From: Ye Xiaolong To: "Burakov, Anatoly" Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190115235423.GA36132@intel.com> References: <20190115154626.34516-1-xiaolong.ye@intel.com> <77b04e1c-e4e1-1b34-910e-c1655b8d0f8e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77b04e1c-e4e1-1b34-910e-c1655b8d0f8e@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove out-of-date comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 23:54:24 -0000 On 01/15, Burakov, Anatoly wrote: >On 15-Jan-19 3:46 PM, Xiaolong Ye wrote: >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c >> index 3cf394bdf..7e69b4498 100644 >> --- a/kernel/linux/igb_uio/igb_uio.c >> +++ b/kernel/linux/igb_uio/igb_uio.c >> @@ -185,11 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state) >> return 0; >> } >> -/** >> - * This is interrupt handler which will check if the interrupt is for the right device. >> - * If yes, disable it here and will be enable later. >> - */ >> -static irqreturn_t >> igbuio_pci_irqhandler(int irq, void *dev_id) >> { >> struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id; >> > >I think you removed one extra line there... oops, thanks for the catch, I'll send a v2. Thanks, Xiaolong > >-- >Thanks, >Anatoly