From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 10441F11 for ; Wed, 16 Jan 2019 06:17:06 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 21:17:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,484,1539673200"; d="scan'208";a="128129530" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga001.jf.intel.com with ESMTP; 15 Jan 2019 21:17:04 -0800 Date: Wed, 16 Jan 2019 13:17:05 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190116051704.GA39571@intel.com> References: <20190115154626.34516-1-xiaolong.ye@intel.com> <20190116003452.37403-1-xiaolong.ye@intel.com> <20190115173822.25a4a979@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115173822.25a4a979@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 05:17:07 -0000 On 01/15, Stephen Hemminger wrote: >On Wed, 16 Jan 2019 08:34:52 +0800 >Xiaolong Ye wrote: > >> The comment for igbuio_pci_irqhandler is out of date as the code evolves, >> remove it to avoid misleading. >> >> Signed-off-by: Xiaolong Ye >> --- >> kernel/linux/igb_uio/igb_uio.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c >> index 3cf394bdf..d6ac51e79 100644 >> --- a/kernel/linux/igb_uio/igb_uio.c >> +++ b/kernel/linux/igb_uio/igb_uio.c >> @@ -185,10 +185,6 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state) >> return 0; >> } >> >> -/** >> - * This is interrupt handler which will check if the interrupt is for the right device. >> - * If yes, disable it here and will be enable later. >> - */ >> static irqreturn_t >> igbuio_pci_irqhandler(int irq, void *dev_id) >> { > >The comment is partially correct; if you look at the legacy case. > >Maybe better to move the comment to pci_check_and_mask_intx in compat.h? >I see there is another incorrect comment there. > Hmm, you're right, this comment is correct for the legacy case, I'll move the comment to pci_check_and_mask_intx as you suggested. Thanks, Xiaolong