DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org, Rosen Xu <rosen.xu@intel.com>
Cc: Andy Pei <andy.pei@intel.com>, stable@dpdk.org, tianfei.zhang@intel.com
Subject: [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs
Date: Fri, 18 Jan 2019 11:07:01 +0000	[thread overview]
Message-ID: <20190118110701.41625-1-ferruh.yigit@intel.com> (raw)
In-Reply-To: <1547430067-63007-1-git-send-email-andy.pei@intel.com>

From: Andy Pei <andy.pei@intel.com>

Original driver requires users to input "afu_bts" args.
But driver can also work without an explicit "afu_bts" args.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
---
Cc: rosen.xu@intel.com
Cc: tianfei.zhang@intel.com
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 5f23ed8b4..e4b7b6f50 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -125,15 +125,13 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
 				     IFPGA_AFU_BTS);
 			goto end;
 		}
+		afu_pr_conf.pr_enable = 1;
 	} else {
-		IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
-			  IFPGA_AFU_BTS);
-		goto end;
+		afu_pr_conf.pr_enable = 0;
 	}
 
 	afu_pr_conf.afu_id.uuid.uuid_low = 0;
 	afu_pr_conf.afu_id.uuid.uuid_high = 0;
-	afu_pr_conf.pr_enable = path?1:0;
 
 	if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
 		goto end;
-- 
2.17.2

  parent reply	other threads:[~2019-01-18 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  1:41 [dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline AndyPei
2019-01-14  5:14 ` Xu, Rosen
2019-01-18 11:07 ` Ferruh Yigit [this message]
2019-01-18 19:02   ` [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118110701.41625-1-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).