From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 839042C36 for ; Tue, 22 Jan 2019 15:24:35 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 06:24:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,506,1539673200"; d="scan'208";a="129760636" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga001.jf.intel.com with SMTP; 22 Jan 2019 06:24:32 -0800 Received: by (sSMTP sendmail emulation); Tue, 22 Jan 2019 14:24:31 +0000 Date: Tue, 22 Jan 2019 14:24:31 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190122142431.GA32516@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190122131054.25196-1-bluca@debian.org> <20190122131054.25196-2-bluca@debian.org> <20190122134653.GB29548@bricha3-MOBL.ger.corp.intel.com> <1548166181.8759.21.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1548166181.8759.21.camel@debian.org> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 14:24:35 -0000 On Tue, Jan 22, 2019 at 02:09:41PM +0000, Luca Boccassi wrote: > On Tue, 2019-01-22 at 13:46 +0000, Bruce Richardson wrote: > > On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote: > > > Whenever possible (if the library ships a pkg-config file) use > > > meson's > > > dependency() function to look for it, as it will automatically add > > > it > > > to the Requires.private list if needed, to allow for static builds > > > to > > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > > dependencies are not parsed, and users doing static builds have to > > > resolve them manually by themselves. > > > When using this API avoid additional checks that are superfluous > > > and > > > take extra time, and avoid adding the linker flag manually which > > > causes > > > it to be duplicated. > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > v2: split libbsd change in a separate commit, remove CC to stable > > >     as a meson bump will be required > > > v4: update comment in drivers/meson.build to clarify role of > > >     pkgconfig_extra_libs > > > v5: remove -lz from drivers/compress/zlib > > > > How is this removal possible? Does drivers/compress/zlib no longer > > depend > > on libz, or is there a dependency added somewhere else in this patch > > that > > I'm missing? Similar question with the -lcrypto removal? > > > > /Bruce > > Note that the removal is from the pkgconfig_extra_libs list - same for > lcrypto. > They use dependency() already, and the dep is added to the ext_deps, so > the dependency comes in that way (and the right flags are picked via > pkg-config). > Ok, that is clear now. I didn't realise that they already used dependency for it. /Bruce