From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 73D6E2C36 for ; Tue, 22 Jan 2019 15:25:19 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 06:25:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,506,1539673200"; d="scan'208";a="129760812" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga001.jf.intel.com with SMTP; 22 Jan 2019 06:25:16 -0800 Received: by (sSMTP sendmail emulation); Tue, 22 Jan 2019 14:25:15 +0000 Date: Tue, 22 Jan 2019 14:25:15 +0000 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190122142515.GB32516@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190122131054.25196-1-bluca@debian.org> <20190122131054.25196-2-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122131054.25196-2-bluca@debian.org> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 14:25:19 -0000 On Tue, Jan 22, 2019 at 01:10:52PM +0000, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for reverse dependencies of DPDK. Otherwise the recursive > dependencies are not parsed, and users doing static builds have to > resolve them manually by themselves. > When using this API avoid additional checks that are superfluous and > take extra time, and avoid adding the linker flag manually which causes > it to be duplicated. > > Signed-off-by: Luca Boccassi > --- > v2: split libbsd change in a separate commit, remove CC to stable > as a meson bump will be required > v4: update comment in drivers/meson.build to clarify role of > pkgconfig_extra_libs > v5: remove -lz from drivers/compress/zlib > This is a good idea. Using dependency objects is much better than trying to track flags manually. Acked-by: Bruce Richardson