From: Ilya Maximets <i.maximets@samsung.com>
To: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
ShuaiX Zhu <shuaix.zhu@intel.com>,
Xueqin Lin <xueqin.lin@intel.com>,
WenjieX A Li <wenjiex.a.li@intel.com>,
FengqinX Wang <fengqinx.wang@intel.com>,
Ilya Maximets <i.maximets@samsung.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] test: test zero socket-mem as valid
Date: Fri, 25 Jan 2019 10:55:58 +0300 [thread overview]
Message-ID: <20190125075558.27139-1-i.maximets@samsung.com> (raw)
In-Reply-To: <CGME20190125075604eucas1p2ecf0177c3f953e889721d784ef387254@eucas1p2.samsung.com>
Dynamic memory mode allowes zero socket-mem because all the
required memory could be allocated on demand.
Fixes: 339c2244b4f1 ("eal: fix parsing zero socket memory and limits")
Cc: stable@dpdk.org
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
test/test/test_eal_flags.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c
index e3a60c7ae..81e345b87 100644
--- a/test/test/test_eal_flags.c
+++ b/test/test/test_eal_flags.c
@@ -1158,7 +1158,7 @@ test_memory_flags(void)
const char *argv1[] = {prgname, "-c", "10", "-n", "2",
"--file-prefix=" memtest, "-m", DEFAULT_MEM_SIZE};
- /* invalid (zero) --socket-mem flag */
+ /* valid (zero) --socket-mem flag */
const char *argv2[] = {prgname, "-c", "10", "-n", "2",
"--file-prefix=" memtest, "--socket-mem=0,0,0,0"};
@@ -1256,8 +1256,8 @@ test_memory_flags(void)
printf("Error - process failed with valid -m flag!\n");
return -1;
}
- if (launch_proc(argv2) == 0) {
- printf("Error - process run ok with invalid (zero) --socket-mem!\n");
+ if (launch_proc(argv2) != 0) {
+ printf("Error - process failed with valid (zero) --socket-mem!\n");
return -1;
}
--
2.17.1
next parent reply other threads:[~2019-01-25 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190125075604eucas1p2ecf0177c3f953e889721d784ef387254@eucas1p2.samsung.com>
2019-01-25 7:55 ` Ilya Maximets [this message]
2019-01-25 8:06 ` Ilya Maximets
2019-01-25 9:53 ` David Marchand
2019-01-25 13:48 ` Burakov, Anatoly
2019-01-25 14:00 ` Ilya Maximets
2019-01-25 14:12 ` Burakov, Anatoly
2019-01-26 18:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125075558.27139-1-i.maximets@samsung.com \
--to=i.maximets@samsung.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=fengqinx.wang@intel.com \
--cc=shuaix.zhu@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenjiex.a.li@intel.com \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).