From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 46C1BF72 for <dev@dpdk.org>; Fri, 25 Jan 2019 21:30:27 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2019 12:30:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,523,1539673200"; d="scan'208";a="111124089" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.245]) by orsmga006.jf.intel.com with SMTP; 25 Jan 2019 12:30:23 -0800 Received: by (sSMTP sendmail emulation); Fri, 25 Jan 2019 20:30:20 +0000 Date: Fri, 25 Jan 2019 20:30:20 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Message-ID: <20190125203019.GA57044@bricha3-MOBL.ger.corp.intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125202642.66559-1-bruce.richardson@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 25 Jan 2019 20:30:27 -0000 On Fri, Jan 25, 2019 at 08:26:38PM +0000, Bruce Richardson wrote: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-pipeline build using meson is to > consolidate all these apps back into the app folder and use the logic > there. The bpf folder doesn't contain an actual application, but > rather example bpf code which can be loaded into testpmd. That is > possibly best moved to the examples folder, but I'm open to feedback > on the best place for it. > > With these changes, the "test" folder then becomes the location for > unit tests only. > > > Bruce Richardson (4): > test/cmdline_test: move to app directory > test/test-acl: move to app directory > test/test-pipeline: move to app directory > test/bpf: move to examples folder > Although these patches are for 19.05, I'm sending them now for some early review, as I think we need a deprecation notice for this change in 19.02 if these changes are acceptable to people. Therefore, please review and let me know any issues people see with this change. /Bruce