From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 54C0C1B398 for ; Wed, 30 Jan 2019 16:26:44 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B026C06A7F2; Wed, 30 Jan 2019 15:26:43 +0000 (UTC) Received: from localhost (dhcp-192-225.str.redhat.com [10.33.192.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87B7D5C260; Wed, 30 Jan 2019 15:26:35 +0000 (UTC) From: Jens Freimann To: dev@dpdk.org Cc: tiwei.bie@intel.com, maxime.coquelin@redhat.com Date: Wed, 30 Jan 2019 16:26:34 +0100 Message-Id: <20190130152634.8652-1-jfreimann@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 30 Jan 2019 15:26:43 +0000 (UTC) Subject: [dpdk-dev] [PATCH] net/virtio: set offload flag for jumbo frames X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 15:26:44 -0000 Port configuration fails when offload flags don't match the expected value, e.g. when max-pkt-len is set to a value that should enable receive port offloading but doesn't. This can be triggered by running testpmd e.g. with --max-pkt-len=2000. It will fail with "Ethdev port_id=0 requested Rx offloads 0x800 doesn't match Rx offloads capabilities 0x20d in rte_eth_dev_configure()" To fix this there are two cases to consider: 1. VIRTIO_NET_F_MTU is negotiated. Then we need to check if the requested max. packet length fits into the MTU. If yes we set the offload flag. 2. VIRTIO_NET_F_MTU is not negotiated. We can set the offload flag. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 7c4c1df00..e0d6542d4 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -2351,6 +2351,17 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) if ((host_features & tso_mask) == tso_mask) dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO; + if (host_features & (1ULL << VIRTIO_NET_F_MTU)) { + struct virtio_net_config config; + vtpci_read_dev_config(hw, + offsetof(struct virtio_net_config, mtu), + &config.mtu, sizeof(config.mtu)); + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= config.mtu) + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME; + } else { + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME; + } + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT; if (host_features & (1ULL << VIRTIO_NET_F_CSUM)) { -- 2.17.2