From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment
Date: Thu, 31 Jan 2019 16:13:37 +0800 [thread overview]
Message-ID: <20190131081337.GB17292@intel.com> (raw)
In-Reply-To: <bfa1e24f-a34e-54dc-13ef-04b31f1150ad@intel.com>
Hi, Ferruh
On 01/29, Ferruh Yigit wrote:
[snip]
>
>Hi Xiaolong,
>
>Your analysis looks correct, thanks for history provided, it seems renaming
>"state" to "status" was not correct [1].
>
>The intention of the 'pci_check_and_mask_intx()' is mask the interrupt if it is
>from this device, so your suggestion looks correct to me.
>
>Only concern is how we can test the change, most probably existing code is also
>failing but able to find its way since it is not tested fully. To be sure we are
>also not missing anything, I think better to test the code before getting it.
>Are you aware of any way to test updated code?
>
Yes, I am also thinking about how to verify the change, will update once I find
a proper method.
>
>And related to the initial patch, removing the comment, I think the comment is
>informative within the context of 'igbuio_pci_irqhandler()', so I suggest moving
>if from begging of the function into it just above legacy interrupt change.
>
Sure, will do.
Thanks,
Xiaolong
>[1]
>5b2f8137 ("igb_uio: fix typos for kernel older than 3.3")
>
>
>Thanks,
>ferruh
prev parent reply other threads:[~2019-01-31 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:46 [dpdk-dev] [PATCH] " Xiaolong Ye
2019-01-15 16:08 ` Burakov, Anatoly
2019-01-15 23:54 ` Ye Xiaolong
2019-01-16 0:34 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-01-16 1:38 ` Stephen Hemminger
2019-01-16 5:17 ` Ye Xiaolong
2019-01-16 7:48 ` Ye Xiaolong
2019-01-16 18:55 ` Stephen Hemminger
2019-01-17 2:13 ` Ye Xiaolong
2019-01-22 1:52 ` Ye Xiaolong
2019-01-29 12:49 ` Ferruh Yigit
2019-01-31 8:13 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131081337.GB17292@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).