From: Bruce Richardson <bruce.richardson@intel.com>
To: Tom Barbette <barbette@kth.se>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Yongseok Koh <yskoh@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C
Date: Thu, 31 Jan 2019 09:11:28 +0000 [thread overview]
Message-ID: <20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se>
On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote:
> Hi all,
>
> Has there been any change regarding this? I'm still at DPDK 18.11. Maybe
> automatically add -Wno-register when C++17 is enabled? Or have a some
> register macro which gets undefined if C++17 is enabled?
>
> The "warning: ISO C++1z does not allow ‘register’ storage class specifier"
> is annoying. And vim always goes to some DPDK header when ":make" fails
> because of the warning...
>
> Thanks,
> Tom
>
What header is that? From what I see the patchset only makes changes to .c
files rather than any .h files, so not sure it would help in your case.
For what it's worth on the general discussion, I'm in favour of applying
this patchset. I view marking variables as "register" as completely
unncessary. If someone can demonstrate a place where it actually makes a
difference, then we can keep that use of the keywork, otherwise I think the
code is as well off without it.
/Bruce
next prev parent reply other threads:[~2019-01-31 9:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 16:30 Stephen Hemminger
2018-07-31 16:30 ` [dpdk-dev] [PATCH 1/5] qat: remove redundant C register keyword Stephen Hemminger
2018-09-05 10:23 ` Jozwiak, TomaszX
2018-07-31 16:30 ` [dpdk-dev] [PATCH 2/5] qede: remove register from declaraitons Stephen Hemminger
2018-07-31 16:30 ` [dpdk-dev] [PATCH 3/5] ark: remove register keyword Stephen Hemminger
2018-07-31 16:30 ` [dpdk-dev] [PATCH 4/5] mlx5: no need for " Stephen Hemminger
2018-07-31 16:30 ` [dpdk-dev] [PATCH 5/5] mlx4: remove redunant " Stephen Hemminger
2018-07-31 16:48 ` [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C Adrien Mazarguil
2018-07-31 18:07 ` Stephen Hemminger
2018-08-01 18:03 ` Yongseok Koh
2018-08-01 21:03 ` Stephen Hemminger
2018-08-23 13:07 ` Ferruh Yigit
2018-10-09 9:19 ` Ferruh Yigit
2019-01-31 8:02 ` Tom Barbette
2019-01-31 9:11 ` Bruce Richardson [this message]
2019-01-31 9:39 ` Tom Barbette
2019-01-31 17:34 ` Wiles, Keith
2018-08-01 10:18 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=barbette@kth.se \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).