From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1A3871B415 for ; Thu, 31 Jan 2019 10:11:33 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 01:11:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="134688233" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga001.jf.intel.com with SMTP; 31 Jan 2019 01:11:30 -0800 Received: by (sSMTP sendmail emulation); Thu, 31 Jan 2019 09:11:28 +0000 Date: Thu, 31 Jan 2019 09:11:28 +0000 From: Bruce Richardson To: Tom Barbette Cc: Ferruh Yigit , Stephen Hemminger , Yongseok Koh , Adrien Mazarguil , "dev@dpdk.org" Message-ID: <20190131091128.GA122080@bricha3-MOBL.ger.corp.intel.com> References: <20180731163059.27085-1-stephen@networkplumber.org> <20180731164840.GD5211@6wind.com> <20180731110737.38555f02@xeon-e3> <50204CDA-B4AD-44C8-AB07-2FE9C2A412C0@mellanox.com> <20180801140356.5ac88c43@xeon-e3> <2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2b06aafe-e444-b773-b5cd-bd0f186e46cd@kth.se> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 09:11:34 -0000 On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote: > Hi all, > > Has there been any change regarding this? I'm still at DPDK 18.11. Maybe > automatically add -Wno-register when C++17 is enabled? Or have a some > register macro which gets undefined if C++17 is enabled? > > The "warning: ISO C++1z does not allow ‘register’ storage class specifier" > is annoying. And vim always goes to some DPDK header when ":make" fails > because of the warning... > > Thanks, > Tom > What header is that? From what I see the patchset only makes changes to .c files rather than any .h files, so not sure it would help in your case. For what it's worth on the general discussion, I'm in favour of applying this patchset. I view marking variables as "register" as completely unncessary. If someone can demonstrate a place where it actually makes a difference, then we can keep that use of the keywork, otherwise I think the code is as well off without it. /Bruce