From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BC2591B415; Thu, 31 Jan 2019 10:17:44 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1215FA6E16; Thu, 31 Jan 2019 09:17:44 +0000 (UTC) Received: from localhost (ovpn-117-143.ams2.redhat.com [10.36.117.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B734418963; Thu, 31 Jan 2019 09:17:37 +0000 (UTC) From: Jens Freimann To: dev@dpdk.org Cc: tiwei.bie@intel.com, maxime.coquelin@redhat.com, stable@dpdk.org Date: Thu, 31 Jan 2019 10:17:36 +0100 Message-Id: <20190131091736.14844-1-jfreimann@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 31 Jan 2019 09:17:44 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3] net/virtio: set offload flag for jumbo frames X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 09:17:45 -0000 Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases to consider: 1. VIRTIO_NET_F_MTU is set. Then we need to check if the requested max-pkt-len fits into the MTU plus header. If yes we set the offload flag. 2. VIRTIO_NET_F_MTU is not set. We can set the offload flag. Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Cc: stable@dpdk.org Signed-off-by: Jens Freimann --- v2->v3: * remove unnecessary brackets (Maxime) * fix commit message (David) v1->v2: * include virtnet hdr, ethernet header, vlan tag when comparing against max-rx-pkt-len (Maxime) drivers/net/virtio/virtio_ethdev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 7c4c1df00..f39d4e630 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -2351,6 +2351,20 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) if ((host_features & tso_mask) == tso_mask) dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TCP_LRO; + if (host_features & (1ULL << VIRTIO_NET_F_MTU)) { + struct virtio_net_config config; + uint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN + + hw->vtnet_hdr_size; + vtpci_read_dev_config(hw, + offsetof(struct virtio_net_config, mtu), + &config.mtu, sizeof(config.mtu)); + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= + config.mtu + ether_hdr_len) + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME; + } else { + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_JUMBO_FRAME; + } + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_VLAN_INSERT; if (host_features & (1ULL << VIRTIO_NET_F_CSUM)) { -- 2.17.2