From: Bruce Richardson <bruce.richardson@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] build: add option to override max ethports
Date: Thu, 31 Jan 2019 09:32:03 +0000 [thread overview]
Message-ID: <20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20190131021858.5832-1-3chas3@gmail.com>
On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote:
> Allow users and packagers to override the default RTE_MAX_ETHPORTS.
> This adds a new meson option, max_ethports which defaults to the
> current value.
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
Agree with the idea. Just one small comment below re alphabetical order.
Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/meson.build | 1 +
> config/rte_config.h | 1 -
> meson_options.txt | 2 ++
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index db32499b3..e59507065 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -103,6 +103,7 @@ endforeach
> # set other values pulled from the build options
> dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores'))
> dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes'))
> +dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports'))
> dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet'))
> dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id'))
> # values which have defaults which may be overridden
> diff --git a/config/rte_config.h b/config/rte_config.h
> index d3732e953..7606f5d7b 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -51,7 +51,6 @@
> #define RTE_PKTMBUF_HEADROOM 128
>
> /* ether defines */
> -#define RTE_MAX_ETHPORTS 32
> #define RTE_MAX_QUEUES_PER_PORT 1024
> #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16
> #define RTE_ETHDEV_RXTX_CALLBACKS 1
> diff --git a/meson_options.txt b/meson_options.txt
> index 574054597..e54eedc66 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -28,3 +28,5 @@ option('use_hpet', type: 'boolean', value: false,
> description: 'use HPET timer in EAL')
> option('tests', type: 'boolean', value: true,
> description: 'build unit tests')
> +option('max_ethports', type: 'string', value: '32',
> + description: 'maximum number of Ethernet devices in EAL')
> --
We are trying to keep the options in alphabetical order, so this setting
should be just before "max_lcores" rather than at the end.
Interestingly, I see that since 0.45 there is now the option of an
"integer" option type. We should probably switch to use that once we bump
our minimum meson version. [Luca, perhaps another change for your set?]
Ref: http://mesonbuild.com/Build-options.html#integers
next prev parent reply other threads:[~2019-01-31 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 2:18 Chas Williams
2019-01-31 9:32 ` Bruce Richardson [this message]
2019-01-31 23:26 ` Chas Williams
2019-02-04 9:46 ` Bruce Richardson
2019-02-06 17:10 ` Luca Boccassi
2019-01-31 23:53 ` [dpdk-dev] [PATCH 1/2 v2] " Chas Williams
2019-02-04 9:49 ` Bruce Richardson
2019-02-05 21:08 ` Chas Williams
2019-01-31 23:59 ` [dpdk-dev] [PATCH 2/2,v2] build: fix option ordering Chas Williams
2019-02-04 9:56 ` Bruce Richardson
2019-02-07 15:53 ` [dpdk-dev] [v3, PATCH 1/2] build: add option to override max ethports Chas Williams
2019-02-07 15:53 ` [dpdk-dev] [v3,PATCH 2/2] build: fix option ordering Chas Williams
2019-02-07 16:35 ` Bruce Richardson
2019-02-26 20:31 ` Thomas Monjalon
2019-02-26 20:19 ` [dpdk-dev] [v3, PATCH 1/2] build: add option to override max ethports Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=3chas3@gmail.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).