* [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM @ 2019-02-03 16:34 Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin ` (3 more replies) 0 siblings, 4 replies; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-03 16:34 UTC (permalink / raw) To: dev, Thomas Monjalon Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 835d8a201..eef480ab5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c LPM M: Bruce Richardson <bruce.richardson@intel.com> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> F: lib/librte_lpm/ F: doc/guides/prog_guide/lpm* F: test/test/test_lpm* -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash 2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin @ 2019-02-03 16:34 ` Vladimir Medvedkin 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin ` (2 subsequent siblings) 3 siblings, 1 reply; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-03 16:34 UTC (permalink / raw) To: dev, Thomas Monjalon Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eef480ab5..81affda53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst F: test/test/test_*hash* F: test/test/test_func_reentrancy.c +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> +F: lib/librte_hash/rte_thash.h + LPM M: Bruce Richardson <bruce.richardson@intel.com> M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin @ 2019-02-05 13:57 ` Vladimir Medvedkin 2019-02-06 10:38 ` Thomas Monjalon 0 siblings, 1 reply; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-05 13:57 UTC (permalink / raw) To: dev, Thomas Monjalon Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- v2: - remove mail footer MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eef480a..81affda 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst F: test/test/test_*hash* F: test/test/test_func_reentrancy.c +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> +F: lib/librte_hash/rte_thash.h + LPM M: Bruce Richardson <bruce.richardson@intel.com> M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> -- 2.7.4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin @ 2019-02-06 10:38 ` Thomas Monjalon 2019-02-07 19:28 ` Medvedkin, Vladimir 0 siblings, 1 reply; 15+ messages in thread From: Thomas Monjalon @ 2019-02-06 10:38 UTC (permalink / raw) To: Vladimir Medvedkin Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara 05/02/2019 14:57, Vladimir Medvedkin: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > +F: lib/librte_hash/rte_thash.h I'm not sure about adding maintainership for one file. You are the author of this file, so you should be consulted during reviews if you don't catch them by yourself. But I prefer seeing maintainers as taking charge and understanding of a full library as a block. And unfortunately, it does not work with the script: devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You would appear as maintainer for all hash files. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-06 10:38 ` Thomas Monjalon @ 2019-02-07 19:28 ` Medvedkin, Vladimir 2019-02-07 21:24 ` Thomas Monjalon 0 siblings, 1 reply; 15+ messages in thread From: Medvedkin, Vladimir @ 2019-02-07 19:28 UTC (permalink / raw) To: Thomas Monjalon Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara On 06/02/2019 10:38, Thomas Monjalon wrote: > 05/02/2019 14:57, Vladimir Medvedkin: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> >> +F: lib/librte_hash/rte_thash.h > I'm not sure about adding maintainership for one file. > You are the author of this file, so you should be consulted > during reviews if you don't catch them by yourself. > But I prefer seeing maintainers as taking charge and understanding of > a full library as a block. > > And unfortunately, it does not work with the script: > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h > You would appear as maintainer for all hash files. It could be solved by adding header. In fact thash is not used by other parts of the hash library (instead it could be used by softnic for example). From my point of view, hash library consists of two parts, hash table itself and a number of hash functions. Hash functions, in turn, can be used for many other purposes, not just for a hash table. Maybe we should separate hash functions and hash table? And if you think it is a bad idea, so be it, 4 maintainers for hash is enough. > > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-07 19:28 ` Medvedkin, Vladimir @ 2019-02-07 21:24 ` Thomas Monjalon 2019-02-07 21:32 ` Gobriel, Sameh 0 siblings, 1 reply; 15+ messages in thread From: Thomas Monjalon @ 2019-02-07 21:24 UTC (permalink / raw) To: Medvedkin, Vladimir Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara, ferruh.yigit 07/02/2019 20:28, Medvedkin, Vladimir: > On 06/02/2019 10:38, Thomas Monjalon wrote: > > 05/02/2019 14:57, Vladimir Medvedkin: > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > >> +F: lib/librte_hash/rte_thash.h > > I'm not sure about adding maintainership for one file. > > You are the author of this file, so you should be consulted > > during reviews if you don't catch them by yourself. > > But I prefer seeing maintainers as taking charge and understanding of > > a full library as a block. > > > > And unfortunately, it does not work with the script: > > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h > > You would appear as maintainer for all hash files. > > It could be solved by adding header. > > In fact thash is not used by other parts of the hash library (instead it > could be used by softnic for example). > > From my point of view, hash library consists of two parts, hash table > itself and a number of hash functions. Hash functions, in turn, can be > used for many other purposes, not just for a hash table. Maybe we should > separate hash functions and hash table? And if you think it is a bad > idea, so be it, 4 maintainers for hash is enough. I don't know. It's opening the door for more split of maintainers areas. I would like to get more opinions from other maintainers, please. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-07 21:24 ` Thomas Monjalon @ 2019-02-07 21:32 ` Gobriel, Sameh 2019-02-07 23:13 ` Wang, Yipeng1 0 siblings, 1 reply; 15+ messages in thread From: Gobriel, Sameh @ 2019-02-07 21:32 UTC (permalink / raw) To: Thomas Monjalon, Medvedkin, Vladimir Cc: dev, Wang, Yipeng1, Richardson, Bruce, De Lara Guarch, Pablo, Yigit, Ferruh I agree with Thomas. It makes sense to separate out hash function from hash table implementation. Sameh -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Thursday, February 7, 2019 1:25 PM To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com> Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 07/02/2019 20:28, Medvedkin, Vladimir: > On 06/02/2019 10:38, Thomas Monjalon wrote: > > 05/02/2019 14:57, Vladimir Medvedkin: > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > >> +F: lib/librte_hash/rte_thash.h > > I'm not sure about adding maintainership for one file. > > You are the author of this file, so you should be consulted during > > reviews if you don't catch them by yourself. > > But I prefer seeing maintainers as taking charge and understanding > > of a full library as a block. > > > > And unfortunately, it does not work with the script: > > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You > > would appear as maintainer for all hash files. > > It could be solved by adding header. > > In fact thash is not used by other parts of the hash library (instead > it could be used by softnic for example). > > From my point of view, hash library consists of two parts, hash table > itself and a number of hash functions. Hash functions, in turn, can be > used for many other purposes, not just for a hash table. Maybe we > should separate hash functions and hash table? And if you think it is > a bad idea, so be it, 4 maintainers for hash is enough. I don't know. It's opening the door for more split of maintainers areas. I would like to get more opinions from other maintainers, please. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-07 21:32 ` Gobriel, Sameh @ 2019-02-07 23:13 ` Wang, Yipeng1 2019-02-08 11:34 ` Medvedkin, Vladimir 0 siblings, 1 reply; 15+ messages in thread From: Wang, Yipeng1 @ 2019-02-07 23:13 UTC (permalink / raw) To: Gobriel, Sameh, Thomas Monjalon, Medvedkin, Vladimir Cc: dev, Richardson, Bruce, De Lara Guarch, Pablo, Yigit, Ferruh Hi Vladimir, Thanks for stepping up for the maintaining job. I agree with you that they are two parts and we mixed hash table and hashing function from beginning. They are actually should be two libraries, but at this Stage it is not very necessary to change the situation yet I think. If you trust us, I will definitely consult with you for questions coming up about thash (also other hash functions like crc and jhash to the corresponding Authors). I will also get more familiar with the code as the maintainer. Thanks Yipeng >-----Original Message----- >From: Gobriel, Sameh >Sent: Thursday, February 7, 2019 1:33 PM >To: Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, >Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com> >Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash > >I agree with Thomas. It makes sense to separate out hash function from hash table implementation. > >Sameh > >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, February 7, 2019 1:25 PM >To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce ><bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com> >Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash > >07/02/2019 20:28, Medvedkin, Vladimir: >> On 06/02/2019 10:38, Thomas Monjalon wrote: >> > 05/02/2019 14:57, Vladimir Medvedkin: >> >> --- a/MAINTAINERS >> >> +++ b/MAINTAINERS >> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> >> >> +F: lib/librte_hash/rte_thash.h >> > I'm not sure about adding maintainership for one file. >> > You are the author of this file, so you should be consulted during >> > reviews if you don't catch them by yourself. >> > But I prefer seeing maintainers as taking charge and understanding >> > of a full library as a block. >> > >> > And unfortunately, it does not work with the script: >> > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You >> > would appear as maintainer for all hash files. >> >> It could be solved by adding header. >> >> In fact thash is not used by other parts of the hash library (instead >> it could be used by softnic for example). >> >> From my point of view, hash library consists of two parts, hash table >> itself and a number of hash functions. Hash functions, in turn, can be >> used for many other purposes, not just for a hash table. Maybe we >> should separate hash functions and hash table? And if you think it is >> a bad idea, so be it, 4 maintainers for hash is enough. > >I don't know. >It's opening the door for more split of maintainers areas. >I would like to get more opinions from other maintainers, please. > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash 2019-02-07 23:13 ` Wang, Yipeng1 @ 2019-02-08 11:34 ` Medvedkin, Vladimir 0 siblings, 0 replies; 15+ messages in thread From: Medvedkin, Vladimir @ 2019-02-08 11:34 UTC (permalink / raw) To: Wang, Yipeng1, Gobriel, Sameh, Thomas Monjalon Cc: dev, Richardson, Bruce, De Lara Guarch, Pablo, Yigit, Ferruh Hi Yipeng, Yes, I agree with you point. So keep me in mind if you decide to split hash table and functions someday :) Thomas, I think this patch could be rejected. Thanks! -----Original Message----- From: Wang, Yipeng1 Sent: Thursday, February 7, 2019 11:14 PM To: Gobriel, Sameh <sameh.gobriel@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com> Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash Hi Vladimir, Thanks for stepping up for the maintaining job. I agree with you that they are two parts and we mixed hash table and hashing function from beginning. They are actually should be two libraries, but at this Stage it is not very necessary to change the situation yet I think. If you trust us, I will definitely consult with you for questions coming up about thash (also other hash functions like crc and jhash to the corresponding Authors). I will also get more familiar with the code as the maintainer. Thanks Yipeng >-----Original Message----- >From: Gobriel, Sameh >Sent: Thursday, February 7, 2019 1:33 PM >To: Thomas Monjalon <thomas@monjalon.net>; Medvedkin, Vladimir ><vladimir.medvedkin@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Richardson, >Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo ><pablo.de.lara.guarch@intel.com>; Yigit, Ferruh ><ferruh.yigit@intel.com> >Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of >Toeplitz hash > >I agree with Thomas. It makes sense to separate out hash function from hash table implementation. > >Sameh > >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, February 7, 2019 1:25 PM >To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com> >Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, >Sameh <sameh.gobriel@intel.com>; Richardson, Bruce ><bruce.richardson@intel.com>; De Lara Guarch, Pablo ><pablo.de.lara.guarch@intel.com>; Yigit, Ferruh ><ferruh.yigit@intel.com> >Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of >Toeplitz hash > >07/02/2019 20:28, Medvedkin, Vladimir: >> On 06/02/2019 10:38, Thomas Monjalon wrote: >> > 05/02/2019 14:57, Vladimir Medvedkin: >> >> --- a/MAINTAINERS >> >> +++ b/MAINTAINERS >> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> >> >> +F: lib/librte_hash/rte_thash.h >> > I'm not sure about adding maintainership for one file. >> > You are the author of this file, so you should be consulted during >> > reviews if you don't catch them by yourself. >> > But I prefer seeing maintainers as taking charge and understanding >> > of a full library as a block. >> > >> > And unfortunately, it does not work with the script: >> > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You >> > would appear as maintainer for all hash files. >> >> It could be solved by adding header. >> >> In fact thash is not used by other parts of the hash library (instead >> it could be used by softnic for example). >> >> From my point of view, hash library consists of two parts, hash >> table itself and a number of hash functions. Hash functions, in turn, >> can be used for many other purposes, not just for a hash table. Maybe >> we should separate hash functions and hash table? And if you think it >> is a bad idea, so be it, 4 maintainers for hash is enough. > >I don't know. >It's opening the door for more split of maintainers areas. >I would like to get more opinions from other maintainers, please. > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag 2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin @ 2019-02-03 16:34 ` Vladimir Medvedkin 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 2019-02-04 9:58 ` [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Bruce Richardson 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 3 siblings, 1 reply; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-03 16:34 UTC (permalink / raw) To: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- lib/librte_hash/rte_thash.h | 33 ++------------------------------- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h index a6ddb7bf7..1b33f4813 100644 --- a/lib/librte_hash/rte_thash.h +++ b/lib/librte_hash/rte_thash.h @@ -1,34 +1,5 @@ -/*- - * BSD LICENSE - * - * Copyright(c) 2015 Vladimir Medvedkin <medvedkinv@gmail.com> - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Intel Corporation nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com> */ #ifndef _RTE_THASH_H -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2] rte_thash: replace license text with SPDX tag 2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin @ 2019-02-05 13:57 ` Vladimir Medvedkin 2019-02-06 10:45 ` Thomas Monjalon 0 siblings, 1 reply; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-05 13:57 UTC (permalink / raw) To: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- v2: - remove mail footer lib/librte_hash/rte_thash.h | 33 ++------------------------------- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h index a6ddb7b..1b33f48 100644 --- a/lib/librte_hash/rte_thash.h +++ b/lib/librte_hash/rte_thash.h @@ -1,34 +1,5 @@ -/*- - * BSD LICENSE - * - * Copyright(c) 2015 Vladimir Medvedkin <medvedkinv@gmail.com> - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Intel Corporation nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com> */ #ifndef _RTE_THASH_H -- 2.7.4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] rte_thash: replace license text with SPDX tag 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin @ 2019-02-06 10:45 ` Thomas Monjalon 0 siblings, 0 replies; 15+ messages in thread From: Thomas Monjalon @ 2019-02-06 10:45 UTC (permalink / raw) To: Vladimir Medvedkin Cc: dev, Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara 05/02/2019 14:57, Vladimir Medvedkin: > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2015-2019 Vladimir Medvedkin <medvedkinv@gmail.com> > */ Applied, thanks ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM 2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin @ 2019-02-04 9:58 ` Bruce Richardson 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 3 siblings, 0 replies; 15+ messages in thread From: Bruce Richardson @ 2019-02-04 9:58 UTC (permalink / raw) To: Vladimir Medvedkin; +Cc: dev, Thomas Monjalon On Sun, Feb 03, 2019 at 04:34:45PM +0000, Vladimir Medvedkin wrote: > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 835d8a201..eef480ab5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c > > LPM > M: Bruce Richardson <bruce.richardson@intel.com> > +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > F: lib/librte_lpm/ > F: doc/guides/prog_guide/lpm* > F: test/test/test_lpm* > -- > 2.17.1 Thanks. Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2] maintainers: claim co-maintainership of LPM 2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin ` (2 preceding siblings ...) 2019-02-04 9:58 ` [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Bruce Richardson @ 2019-02-05 13:57 ` Vladimir Medvedkin 2019-02-06 10:41 ` Thomas Monjalon 3 siblings, 1 reply; 15+ messages in thread From: Vladimir Medvedkin @ 2019-02-05 13:57 UTC (permalink / raw) To: dev, Thomas Monjalon Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com> --- v2: - remove mail footer MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 835d8a2..eef480a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c LPM M: Bruce Richardson <bruce.richardson@intel.com> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> F: lib/librte_lpm/ F: doc/guides/prog_guide/lpm* F: test/test/test_lpm* -- 2.7.4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2] maintainers: claim co-maintainership of LPM 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin @ 2019-02-06 10:41 ` Thomas Monjalon 0 siblings, 0 replies; 15+ messages in thread From: Thomas Monjalon @ 2019-02-06 10:41 UTC (permalink / raw) To: Vladimir Medvedkin; +Cc: dev 05/02/2019 14:57, Vladimir Medvedkin: > --- a/MAINTAINERS > +++ b/MAINTAINERS > LPM > M: Bruce Richardson <bruce.richardson@intel.com> > +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com> > F: lib/librte_lpm/ > F: doc/guides/prog_guide/lpm* > F: test/test/test_lpm* Acked-by: Bruce Richardson <bruce.richardson@intel.com> (from v1) Applied, thanks ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-02-08 11:34 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin 2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 2019-02-06 10:38 ` Thomas Monjalon 2019-02-07 19:28 ` Medvedkin, Vladimir 2019-02-07 21:24 ` Thomas Monjalon 2019-02-07 21:32 ` Gobriel, Sameh 2019-02-07 23:13 ` Wang, Yipeng1 2019-02-08 11:34 ` Medvedkin, Vladimir 2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 2019-02-06 10:45 ` Thomas Monjalon 2019-02-04 9:58 ` [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Bruce Richardson 2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin 2019-02-06 10:41 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).