From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 07B321B0F7 for ; Mon, 4 Feb 2019 10:49:10 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2019 01:49:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,559,1539673200"; d="scan'208";a="115094041" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.138]) by orsmga008.jf.intel.com with SMTP; 04 Feb 2019 01:49:07 -0800 Received: by (sSMTP sendmail emulation); Mon, 04 Feb 2019 10:49:07 +0100 Date: Mon, 4 Feb 2019 10:49:06 +0100 From: Bruce Richardson To: Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20190204094906.GC21148@bricha3-MOBL.ger.corp.intel.com> References: <20190131021858.5832-1-3chas3@gmail.com> <20190131235326.10648-1-3chas3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131235326.10648-1-3chas3@gmail.com> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH 1/2 v2] build: add option to override max ethports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 09:49:11 -0000 On Thu, Jan 31, 2019 at 06:53:25PM -0500, Chas Williams wrote: > Allow users and packagers to override the default RTE_MAX_ETHPORTS. > This adds a new meson option, max_ethports which defaults to the > current value. > Actually in this v2, you have changed it to 64 from 32. :-) Otherwise all fine, but perhaps this can be fixed on apply if no v3. > Signed-off-by: Chas Williams <3chas3@gmail.com> > Acked-by: Bruce Richardson > --- > config/meson.build | 1 + > config/rte_config.h | 1 - > meson_options.txt | 2 ++ > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index db32499b3..e59507065 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -103,6 +103,7 @@ endforeach > # set other values pulled from the build options > dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores')) > dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes')) > +dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) > dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet')) > dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id')) > # values which have defaults which may be overridden > diff --git a/config/rte_config.h b/config/rte_config.h > index d3732e953..7606f5d7b 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -51,7 +51,6 @@ > #define RTE_PKTMBUF_HEADROOM 128 > > /* ether defines */ > -#define RTE_MAX_ETHPORTS 32 > #define RTE_MAX_QUEUES_PER_PORT 1024 > #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 > #define RTE_ETHDEV_RXTX_CALLBACKS 1 > diff --git a/meson_options.txt b/meson_options.txt > index 574054597..499573ed4 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -18,6 +18,8 @@ option('lib_musdk_dir', type: 'string', value: '', > description: 'path to the MUSDK library installation directory') > option('machine', type: 'string', value: 'native', > description: 'set the target machine type') > +option('max_ethports', type: 'string', value: '64', > + description: 'maximum number of Ethernet devices in EAL') > option('max_lcores', type: 'string', value: '128', > description: 'maximum number of cores/threads supported by EAL') > option('max_numa_nodes', type: 'string', value: '4', > -- > 2.17.2 >