From: Stephen Hemminger <stephen@networkplumber.org>
To: Pallantla Poornima <pallantlax.poornima@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, yipeng1.wang@intel.com,
sameh.gobriel@intel.com, bruce.richardson@intel.com,
pablo.de.lara.guarch@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] hash: fix sprintf with snprintf
Date: Wed, 6 Feb 2019 08:18:16 -0800 [thread overview]
Message-ID: <20190206081816.648c0f12@hermes.lan> (raw)
In-Reply-To: <1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com>
On Wed, 6 Feb 2019 10:52:17 +0000
Pallantla Poornima <pallantlax.poornima@intel.com> wrote:
> + snprintf(name, sizeof(name), "test_hash%d_data",
> + hashtest_key_lens[table_index]);
It looks like %u should be used since hashtest_key_lens is unsigned
32 bit value.
Since the values in table are always small enough, I don't see why
this should go to stable.
prev parent reply other threads:[~2019-02-06 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:52 Pallantla Poornima
2019-02-06 16:18 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206081816.648c0f12@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).