From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id A76161B396 for ; Wed, 6 Feb 2019 17:18:25 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id e5so3299930plb.5 for ; Wed, 06 Feb 2019 08:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SVXsxRgiKbLFOBDaPPaAsagjoditKa87/R6UnDG5sLY=; b=Z6wSrbZpfF53KeEMy4/fKbsbDEOOX7mSXyYeWFfysfBSP0KgFXfg0P/azMfdNicz3Q lbocv+FawPoMkwXCXOboNpZbqHiLYPUXcS98oUxMgMIpQY/4RtYCgARk63C3+XVrXaJR xEyD0lEwwWilROFdKWVw5BSdqNkouVYbJTUGdenmvQTVTSZ+V8SSGDRd/D/oXRD5Tj6+ kj83WCpTCBW4Gwnb58EdsS/iInQnwqlLOfc+8x/cIyQo5UP4Btenrnr6aD9XZTSoJHM2 3Mt1NYmjcsnUdFcEjaX+l0KIB3D5gaQTYgB6o6w6JHBJEDvUjjK93JbDdD+lgSVDOtu2 LMaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SVXsxRgiKbLFOBDaPPaAsagjoditKa87/R6UnDG5sLY=; b=qEBrgRydb7APcT+oND04HWSQB6qYlktKPyAThAUDjy8EAYkkXMWVJ4+3pSH5Sk+31b 75brFBd7WFY+/b0UzGylN9Qki5z0IkymbH10KX600f8AEyj9u31wZDRUATg21CCJZS2s xNUH/XYru4R4Qr1N2B+NV3bJLCDDPMEgzP8ofLnqEfox2Hw9XugtE3ywo78GSz+IQP0C f0bR0DoPdJAqUOebnT3yh0f/AJVERbNVMF/fa2WxUwwUqWTEJxTeuLEyDqKg8u7cZTWT BuE9FlOTaW3asx96suUEEWZSHhCa5ImiIqqmCQLcyOCngU+zmS7vxKVHnejv0ObURL2j UwRQ== X-Gm-Message-State: AHQUAuY9wkEyS5LX80Q7rJegQrFdtra6WAuMUj1w3yxDdQC2zLBwNfSM bvWWH9V3dpF9egb0C7A3JQhwdeT8+HQ= X-Google-Smtp-Source: AHgI3Iaav18sq0FZhRTr6y6Mt60FT2+ksh0WTGpJtQ4SXVJmxdybr3HwIthuKSoAUmR1RgB1oyS7dA== X-Received: by 2002:a17:902:e013:: with SMTP id ca19mr5233915plb.46.1549469904831; Wed, 06 Feb 2019 08:18:24 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f6sm10577741pfg.188.2019.02.06.08.18.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 08:18:24 -0800 (PST) Date: Wed, 6 Feb 2019 08:18:16 -0800 From: Stephen Hemminger To: Pallantla Poornima Cc: dev@dpdk.org, reshma.pattan@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, stable@dpdk.org Message-ID: <20190206081816.648c0f12@hermes.lan> In-Reply-To: <1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com> References: <1549450337-2890-1-git-send-email-pallantlax.poornima@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] hash: fix sprintf with snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 16:18:26 -0000 On Wed, 6 Feb 2019 10:52:17 +0000 Pallantla Poornima wrote: > + snprintf(name, sizeof(name), "test_hash%d_data", > + hashtest_key_lens[table_index]); It looks like %u should be used since hashtest_key_lens is unsigned 32 bit value. Since the values in table are always small enough, I don't see why this should go to stable.