* [dpdk-dev] [PATCH] power: fix frequency list buffer validation
@ 2019-02-06 12:19 Kevin Traynor
2019-03-29 14:00 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Traynor @ 2019-02-06 12:19 UTC (permalink / raw)
To: david.hunt, dev; +Cc: Kevin Traynor, stable
The frequency list buffer was already validated in
power_acpi_cpufreq_freqs(), so the newly added check was redundant.
To keep consistency with power_pstate_cpufreq_freqs(), remove the
original check and update the log message.
Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")
Cc: stable@dpdk.org
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/librte_power/power_acpi_cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
index 45412f0b9..534efe817 100644
--- a/lib/librte_power/power_acpi_cpufreq.c
+++ b/lib/librte_power/power_acpi_cpufreq.c
@@ -441,6 +441,6 @@ power_acpi_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
struct rte_power_info *pi;
- if (lcore_id >= RTE_MAX_LCORE || !freqs) {
- RTE_LOG(ERR, POWER, "Invalid input parameter\n");
+ if (lcore_id >= RTE_MAX_LCORE) {
+ RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
return 0;
}
--
2.19.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] power: fix frequency list buffer validation
2019-02-06 12:19 [dpdk-dev] [PATCH] power: fix frequency list buffer validation Kevin Traynor
@ 2019-03-29 14:00 ` Thomas Monjalon
2019-03-29 14:00 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-03-29 14:00 UTC (permalink / raw)
To: Kevin Traynor; +Cc: stable, david.hunt, dev
06/02/2019 13:19, Kevin Traynor:
> The frequency list buffer was already validated in
> power_acpi_cpufreq_freqs(), so the newly added check was redundant.
> To keep consistency with power_pstate_cpufreq_freqs(), remove the
> original check and update the log message.
>
> Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
In absence of review, applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] power: fix frequency list buffer validation
2019-03-29 14:00 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2019-03-29 14:00 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-03-29 14:00 UTC (permalink / raw)
To: Kevin Traynor; +Cc: stable, david.hunt, dev
06/02/2019 13:19, Kevin Traynor:
> The frequency list buffer was already validated in
> power_acpi_cpufreq_freqs(), so the newly added check was redundant.
> To keep consistency with power_pstate_cpufreq_freqs(), remove the
> original check and update the log message.
>
> Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
In absence of review, applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-06 12:19 [dpdk-dev] [PATCH] power: fix frequency list buffer validation Kevin Traynor
2019-03-29 14:00 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-29 14:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).