From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 64EF31B464 for ; Wed, 6 Feb 2019 23:27:35 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id z11so3586855pgu.0 for ; Wed, 06 Feb 2019 14:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rTC7ybcUKd6K7M/s3vPkasDx8qTNGgdiE8I1naQpCVw=; b=aTb0ccDhO1H1C6/YWNlWXqzRsIJWB+/WrYcIJiL0wDAJdAGVTT9TMu7Nq/QHdUuQCU 4skGSktTUDqLuOxQRAXcFOpyTOuG9TLzAvCEO2lGEV8OTmtmw+5OQj6zNtSJHNtwv92I +fnynUQhSrxCO8WRg6UUd5MliAgRDz7XwHnBl5UyYD/ZVjuVpVQIH7y0KzBxzX8Ab4fg 0H8GmWmd4HZkq0m+NmYMmKI5CK3rf4IqcpdXU38CzHZCrXLPxGd6B+Z6cvzQ0MyyrYTR J0AhRDxkUbTIXuGxA241IK0/h0IHGHN41/B7bAfRTjgEC7mI518vCPrYYLeWH4cqP0DY x1wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rTC7ybcUKd6K7M/s3vPkasDx8qTNGgdiE8I1naQpCVw=; b=Ity/abn96cUVXygTQ63O++ULje+6ws9/OaWP/8CweWuuLxXhNoeJ6AApX/ORLsCkVq v29iYBENoyUEzsLk5bvZKpRTU5Ca+t3Rl27Xe6+v/R5oaAAxKKJlxPcTMTWBu/UAdZDc rkSFDAhfgbQ7EcRwGrm/wMdg7PzLkEtRIUJvXte75VMwB4VaKSNyflhkvMjyOLiWIIb2 9scyp7iSi3yYq4CDJo3jPblLfONnYSxGsIvTv2a7zlp5TqYEePUklNxJAzgUPbUPUi6F HIoBE8d+5w0fLT1MIV7dpzlKikL8TE3qRDoOLrO9nl7uPHb0RLe6ybEiuHTq9RPxFYiT O2iA== X-Gm-Message-State: AHQUAuZz13O1ZCLOJEtYmM8KLTihIYaEOIo/GoyyeFiSEDnbLoHm6+Yu CTGS/Sw4zL7eVLjHw7ApgrKoEw== X-Google-Smtp-Source: AHgI3IZCk8gah83zUbhP/dpQDFVnou3YVMxDhyWr9bncTcUcJDBA3kCdu/0JgY/7OEDtSPbfVOugfg== X-Received: by 2002:a63:f743:: with SMTP id f3mr2763606pgk.244.1549492054539; Wed, 06 Feb 2019 14:27:34 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 84sm9055736pfk.134.2019.02.06.14.27.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 14:27:34 -0800 (PST) Date: Wed, 6 Feb 2019 14:27:26 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Matan Azrad , Shahaf Shuler , Yongseok Koh , dev@dpdk.org Message-ID: <20190206142726.7f5395cc@hermes.lan> In-Reply-To: <1561267.IqWJBFvPPj@xps> References: <20190206215909.30147-1-thomas@monjalon.net> <20190206141648.5f2d6a99@hermes.lan> <1561267.IqWJBFvPPj@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx: support firmware version query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 22:27:35 -0000 On Wed, 06 Feb 2019 23:23:07 +0100 Thomas Monjalon wrote: > 06/02/2019 23:16, Stephen Hemminger: > > On Wed, 6 Feb 2019 22:59:09 +0100 > > Thomas Monjalon wrote: > > > > > The API function rte_eth_dev_fw_version_get() is querying drivers > > > via the operation callback fw_version_get(). > > > The implementation of this operation is added for mlx4 and mlx5. > > > Both functions are copying the same ibverbs field fw_ver > > > which is retrieved when calling ibv_query_device[_ex]() > > > during the port probing. > > > > > > It is tested with command "drvinfo" of examples/ethtool/. > > > > > > Signed-off-by: Thomas Monjalon > > > > Looks good, but hard to test because: > > * testpmd doesn't report it > > Yes, good idea, we should do this query somewhere in testpmd. > Can be a separate command or part of some other infos. > > > * with netvsc (and failsafe) the device is owned and not visible > > > > Fixing testpmd is not hard, but what is best way to handle > > the nested device situation. > > I am not sure we want to expose such info via failsafe or bonding. > If we are interested to know the underlying hardware, we should > access directly to the nested device. The nested devices are not visible in testpmd (or other applications that iterate over ports).