From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D301A1B3B5; Thu, 7 Feb 2019 14:27:42 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2019 05:27:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,344,1544515200"; d="scan'208";a="136628552" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54]) by orsmga001.jf.intel.com with SMTP; 07 Feb 2019 05:27:37 -0800 Received: by (sSMTP sendmail emulation); Thu, 07 Feb 2019 13:27:36 +0000 Date: Thu, 7 Feb 2019 13:27:36 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: "Parthasarathy, JananeeX M" , "dev@dpdk.org" , "rmody@marvell.com" , "Pattan, Reshma" , "shshaikh@marvell.com" , "Xing, Beilei" , "Zhang, Qi Z" , "alejandro.lucero@netronome.com" , "De Lara Guarch, Pablo" , "Doherty, Declan" , "Chaitanya Babu, TalluriX" , "stable@dpdk.org" , Thomas Monjalon Message-ID: <20190207132736.GA61876@bricha3-MOBL.ger.corp.intel.com> References: <1547445875-24601-1-git-send-email-tallurix.chaitanya.babu@intel.com> <1547825033-3595-1-git-send-email-tallurix.chaitanya.babu@intel.com> <7AE31235A30B41498D1C31348DC858BD5B5217F4@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 13:27:43 -0000 On Thu, Feb 07, 2019 at 11:56:30AM +0000, Ferruh Yigit wrote: > On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote: > > > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chaitanya Babu Talluri > >> Sent: Friday, January 18, 2019 8:54 PM > >> To: dev@dpdk.org > >> Cc: rmody@marvell.com; Pattan, Reshma ; > >> shshaikh@marvell.com; Xing, Beilei ; Zhang, Qi Z > >> ; alejandro.lucero@netronome.com; De Lara Guarch, > >> Pablo ; Doherty, Declan > >> ; Chaitanya Babu, TalluriX > >> ; stable@dpdk.org > >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat > >> > >> Strcat does not check the destination length and there might be chances of > >> string overflow so insted of strcat, strncat is used. > >> > >> Fixes: 540a211084 ("bnx2x: driver core") > >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess") > >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Chaitanya Babu Talluri > > <...> > > > > > Any Review Please!! > > > > cc'ed Bruce & Thomas. > > What do you think getting strlcat() patch first and updating this patch to use > strlcat()? > > Are we OK to get strlcat as the default API? > "strlcat" is just saner to use, so +1 for this approach. /Bruce