From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id DF9381B39C for ; Tue, 12 Feb 2019 12:31:58 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 03:31:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,361,1544515200"; d="scan'208";a="318310912" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga006.fm.intel.com with SMTP; 12 Feb 2019 03:31:53 -0800 Received: by (sSMTP sendmail emulation); Tue, 12 Feb 2019 11:31:55 +0000 Date: Tue, 12 Feb 2019 11:31:54 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Luca Boccassi , dev@dpdk.org Message-ID: <20190212113154.GA517812@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190206170848.19059-1-bluca@debian.org> <20190206170848.19059-2-bluca@debian.org> <3082304.pESdSe8qVs@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3082304.pESdSe8qVs@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 11:31:59 -0000 On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote: > 06/02/2019 18:08, Luca Boccassi: > > Whenever possible (if the library ships a pkg-config file) use meson's > > dependency() function to look for it, as it will automatically add it > > to the Requires.private list if needed, to allow for static builds to > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > dependencies are not parsed, and users doing static builds have to > > resolve them manually by themselves. > > When using this API avoid additional checks that are superfluous and > > take extra time, and avoid adding the linker flag manually which causes > > it to be duplicated. > > > > Signed-off-by: Luca Boccassi > > Acked-by: Bruce Richardson > > This patch breaks compilation on my machine with a lot of strange errors: > > from drivers/net/pcap/rte_eth_pcap.c > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' qualifier from pointer target type > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored > etc > Is this on Arch linux again? I just reverified these first two patches and they work fine for me on Fedora (I assume Luca probably tested them already on Debian) Anything unusual about your setup? /Bruce