From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B06F21B163 for ; Thu, 14 Feb 2019 15:07:39 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2019 06:07:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,369,1544515200"; d="scan'208";a="144252079" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by fmsmga004.fm.intel.com with SMTP; 14 Feb 2019 06:07:36 -0800 Received: by (sSMTP sendmail emulation); Thu, 14 Feb 2019 14:07:35 +0000 Date: Thu, 14 Feb 2019 14:07:35 +0000 From: Bruce Richardson To: "Van Haaren, Harry" Cc: Michael Santana , "dev@dpdk.org" , Thomas Monjalon Message-ID: <20190214140735.GB734836@bricha3-MOBL.ger.corp.intel.com> References: <20190213190813.12702-1-msantana@redhat.com> <20190213190813.12702-2-msantana@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 14:07:40 -0000 On Wed, Feb 13, 2019 at 07:16:24PM +0000, Van Haaren, Harry wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Santana > > Sent: Wednesday, February 13, 2019 7:08 PM > > To: dev@dpdk.org > > Cc: Thomas Monjalon > > Subject: [dpdk-dev] [PATCH 1/2] Enable codespell from config file. > > > > Enable turning on codespell from any of the config files for > > checkpatches.sh. codespell is a feature by checkpatch.pl that > > checks for common spelling mistakes in comments in patches. > > > > This feature is disabled by default. To enable it one must add > > the '--codespell' flag to the $options variable in > > checkpatches.sh. With this change the user can decide to turn > > on codespell from a config file rather than directly modifying > > checkpatches.sh > > > > Signed-off-by: Michael Santana > > Oh nice, I didn't know checkpatch had a spell check available. > > Would it make sense to turn on automatically if the required spelling program is available? > > (Perhaps provide an explicit disable if certain people hate the idea..) > > I'm a +1 for tools just doing the right thing by default :) > +1 for on by default.