From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1F3331B4A6 for ; Thu, 14 Feb 2019 20:35:51 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F30F8BD26; Thu, 14 Feb 2019 19:35:50 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8F3C19C65; Thu, 14 Feb 2019 19:35:49 +0000 (UTC) From: Michael Santana To: dev@dpdk.org Cc: Thomas Monjalon , Van Haaren Harry , ramirose@gmail.com, Bruce Richardson Date: Thu, 14 Feb 2019 14:35:47 -0500 Message-Id: <20190214193547.30783-3-msantana@redhat.com> In-Reply-To: <20190214193547.30783-1-msantana@redhat.com> References: <20190213190813.12702-1-msantana@redhat.com> <20190214193547.30783-1-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 14 Feb 2019 19:35:50 +0000 (UTC) Subject: [dpdk-dev] [PATCH v2 2/2] Fix variable assignment. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 19:35:51 -0000 Fix trivial bug. In sh shell, 'foo = 1' is not the same as 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo as a command, rather than a simple variable assignment. Signed-off-by: Michael Santana Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot") --- v2: Nothing changed since v1. devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 9c2b0a28a..8852b9412 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -68,7 +68,7 @@ check_forbidden_additions() { # -v RET_ON_FAIL=1 \ -v MESSAGE='Using explicit .svg extension instead of .*' \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \ - "$1" || res = 1 + "$1" || res=1 return $res } -- 2.20.1