From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 831CC2AB for ; Wed, 20 Feb 2019 03:25:46 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 18:25:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,388,1544515200"; d="scan'208";a="135630655" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga002.jf.intel.com with ESMTP; 19 Feb 2019 18:25:44 -0800 Date: Wed, 20 Feb 2019 10:23:04 +0800 From: Tiwei Bie To: Jason Wang Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20190220022304.GB27316@dpdk-tbie.sh.intel.com> References: <20190219105951.31046-1-tiwei.bie@intel.com> <6226c4fc-9671-451c-cb60-0b03a6216080@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6226c4fc-9671-451c-cb60-0b03a6216080@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 0/5] Fixes and enhancements for Tx path in Virtio PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 02:25:46 -0000 On Tue, Feb 19, 2019 at 09:40:05PM +0800, Jason Wang wrote: > On 2019/2/19 下午6:59, Tiwei Bie wrote: > > Below is a quick (unofficial) performance test (macfwd loop, 64B) > > for the packed ring optimizations in this series on an Intel(R) > > Xeon(R) Gold 6140 CPU @ 2.30GHz platform: > > > > w/o this series: > > packed ring normal/in-order: ~10.4 Mpps > > > > w/ this series: > > packed ring normal: ~10.9 Mpps > > packed ring in-order: ~11.3 Mpps > > > Since your series contain optimization for split ring as well. I wonder > whether you have its numbers as well. The PPS of split ring in-order (with or without this series) showed by testpmd isn't stable in my above test. So I didn't manage to get some numbers.. > > Thanks > > > > > > In the test, we need to make sure that the vhost side is fast enough. > > So 4 forwarding cores are used in vhost side, and 1 forwarding core is > > used in virtio side. > > > > vhost side: > > > > ./x86_64-native-linuxapp-gcc/app/testpmd \ > > -l 13,14,15,16,17 \ > > --socket-mem 1024,0 \ > > --file-prefix=vhost \ > > --vdev=net_vhost0,iface=/tmp/vhost0,queues=4 \ > > -- \ > > --forward-mode=mac \ > > -i \ > > --rxq=4 \ > > --txq=4 \ > > --nb-cores 4 > > > > virtio side: > > > > ./x86_64-native-linuxapp-gcc/app/testpmd \ > > -l 8,9,10,11,12 \ > > --socket-mem 1024,0 \ > > --single-file-segments \ > > --file-prefix=virtio-user \ > > --vdev=virtio_user0,path=/tmp/vhost0,queues=4,in_order=1,packed_vq=1 \ > > -- \ > > --forward-mode=mac \ > > -i \ > > --rxq=4 \ > > --txq=4 \ > > --nb-cores 1 > > > > > > Tiwei Bie (5): > > net/virtio: fix Tx desc cleanup for packed ring > > net/virtio: fix in-order Tx path for split ring > > net/virtio: fix in-order Tx path for packed ring > > net/virtio: introduce a helper for clearing net header > > net/virtio: optimize xmit enqueue for packed ring > > > > drivers/net/virtio/virtio_ethdev.c | 4 +- > > drivers/net/virtio/virtio_rxtx.c | 203 ++++++++++++++++++++--------- > > 2 files changed, 146 insertions(+), 61 deletions(-) > >