From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 096361E34 for ; Thu, 21 Feb 2019 00:08:29 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id d25so4344380pfn.8 for ; Wed, 20 Feb 2019 15:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2bZfAO5E6wMUCqQNBMaOJMOx4sOzZaLDTfvroMMKjHA=; b=GsMZ+J2WDsu2X7HHK+VVvN2O8OvkBr2baL9k+Q3d0aF3pt2OeuftY3WB+c2X4yy1ag BoqQmy819pgPPLQ5zXqSzye6fIId04aXnld0yKfSjhS12xN9fn6ZpkmK7axMoEKzPZOM jthi51akelxRxyt/JttFEyHxsva/mHarEr91T1xEVvebobFl9/Lr7qqf0HXowpQupWMd b6oUqy/4ZZ4PZ/SVWN6eQu2Fedv1xiC8dyCNRihB8F9SD4+6i4aJPh8nCcKZ4s0Fzj1H Epwad6WBgoC5IaYfmBnW/d9hHy8wuSDFHMHEADiqkCzswQl6CJZ5kXvYkdtUTj04IUoB WIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2bZfAO5E6wMUCqQNBMaOJMOx4sOzZaLDTfvroMMKjHA=; b=q+2GFxmpq1UQ6bAuwTvXeMlnO3B21kxCuDSSQOyACJtPM2d9PFAirq0A4JjcLUtXvm /lRYLURx6JM5JOs5qguR/9WYCNNcijo9qABPY8YRNFQk2D0M7tPahywKKn9SsFPlRkMI 5wBOPuwePCxmtVc4ZK1E31b09nmhsBtf/DqIDbH2tq+RoZ8+4JaPJ3w7niSO5XDAvFwz OTXfIZZ3aAqP+9celD/+KKnKhyL0DOBpje80LvTHCUd8Ws4Uk3HdHsSklj4P/+3mkO3G q7patOMB4BvG8YaqqEI7NeqUSJmhgVXGARsGUCtym8aSNS21rn5IoUy2aecebwpETOqX yEcw== X-Gm-Message-State: AHQUAub50aKtmBJF4C/vj9VBFW6gxm1/m9ZRtzgILLBRi+VBGXkXZm1p F2fjDYyDuoBI9YcgqbySkMpmDA== X-Google-Smtp-Source: AHgI3IYrpuRk7FMsDFWcAMqULMAmkh+K1z51cntZiEsSSerAbow+TAOjZ5YyQ89oNYQr9rDJ0QFXfA== X-Received: by 2002:a63:e14e:: with SMTP id h14mr20798046pgk.184.1550704106772; Wed, 20 Feb 2019 15:08:26 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z6sm18767283pgo.31.2019.02.20.15.08.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 15:08:26 -0800 (PST) Date: Wed, 20 Feb 2019 15:08:23 -0800 From: Stephen Hemminger To: Dharmik Thakkar Cc: dev@dpdk.org Message-ID: <20190220150823.69a3cb3e@shemminger-XPS-13-9360> In-Reply-To: <20190220230023.17029-1-dharmik.thakkar@arm.com> References: <20190220224714.16303-1-dharmik.thakkar@arm.com> <20190220230023.17029-1-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 23:08:29 -0000 On Wed, 20 Feb 2019 17:00:20 -0600 Dharmik Thakkar wrote: > Currently, in test code, for printing extra information, > compilation time options are used. This approach does not compile the > code always. Macro needs to be set for the code to compile. > > This patchset replaces compilation time option with log level based > approach, thus enabling compilation of code always. Log levels can be > set using eal parameters. > > Dharmik Thakkar (3): > test/hash: replace macro with log-level approach > test/efd: enable unit test compilation always > test/timer: enable unit test compilation always > > test/test/test_efd.c | 24 ++++++++---------------- > test/test/test_hash.c | 3 +-- > test/test/test_timer_racecond.c | 23 ++++++++++------------- > 3 files changed, 19 insertions(+), 31 deletions(-) > Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)