From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id C678E235; Wed, 20 Feb 2019 16:17:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1674; q=dns/txt; s=iport; t=1550675833; x=1551885433; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=s6GzNq0LoyWCSXGy/zn0PyFclEsUAxZCsjiBbxdvntQ=; b=AHlhIxTSuC742WHM2Nal1Mra0SpN4saZj7t8m3ju+mbRiqp/kUayY9VZ tO4VWcgWpCf9SHyXL3FW+cpJsUsjrh8YGF6Ywhoa8DrBuKtOU5zekZXGE PaayV+di3ZnOxUAyGiJQN1XOKXs1LV1zK0C4WucYmbB0KL7uHMM72M8Xj E=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAABIb21c/4UNJK1kGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggNnUTInjCGLaoINmBwUgWcLAQEfhE0?= =?us-ascii?q?Cg3QiNAkNAQMBAQIBAQJtHAyFSwEFJxM/EAsYCR4HDwUyFxODIYFyD64sM4F?= =?us-ascii?q?6gjUBhgEFjEQRBoFAP4QjhGqDUYImAoliBBOCFIVEkXsJhzyLEiWBcIVXiz+?= =?us-ascii?q?LV4Q9jDcCBAYFAhSBRziBVjMaCBsVO4Jsix6FTjADMAGQCgEB?= X-IronPort-AV: E=Sophos;i="5.58,391,1544486400"; d="scan'208";a="239248312" Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 15:16:58 +0000 Received: from HYONKIM-7R0DR.cisco.com ([10.24.60.224]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id x1KFGq89017285 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 Feb 2019 15:16:56 GMT Date: Thu, 21 Feb 2019 00:16:52 +0900 From: Hyong Youb Kim To: Radu Nicolau Cc: Ferruh Yigit , Hari Kumar Vemula , dev@dpdk.org, "Pattan, Reshma" , JananeeX M , Declan , stable@dpdk.org Message-ID: <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com> References: <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com> <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com> <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Outbound-SMTP-Client: 10.24.60.224, [10.24.60.224] X-Outbound-Node: alln-core-11.cisco.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 15:17:13 -0000 On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote: > > > On 2/20/2019 12:33 PM, Ferruh Yigit wrote: > > On 2/18/2019 3:58 PM, Radu Nicolau wrote: > > > > > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote: > > > > test_alb_reply_from_client test fails due to incorrect active slave > > > > array's index. This was due to invalid active slave count. > > > > > > > > Count of internals->active_slave is not updated even when active slave > > > > is deactivated. > > > > Hence active slave count always keeps incrementing beyond the actual > > > > active slaves. > > > > > > > > Fix is to set the internals->active_slave to starting index 0 whenever > > > > it exceeds the number of slaves in active slave list and also update > > > > the active slave count during slave de-activation. > > > > > > > > Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Hari Kumar Vemula > > > > --- > > > > > > > Acked-by: Radu Nicolau > > > > > Hi Radu, Hari, > > > > There is another bonding patch, can you please check how related are they and if > > are these fixing same root cause: > > > > net/bonding: avoid the next active slave going out of bound > > https://patches.dpdk.org/patch/49573/ > > > Hi, it's a similar fix for the same root cause, but this one covers more (or > all) situations that can cause active_slave to go out of bounds. If it covers more cases, please go with the new patch and drop mine. I just want to see the issue fixed :-) Thanks. -Hyong