From: Dharmik Thakkar <dharmik.thakkar@arm.com>
To: Robert Sanford <rsanford@akamai.com>
Cc: dev@dpdk.org, Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-dev] [PATCH v2 3/3] test/timer: enable unit test compilation always
Date: Wed, 20 Feb 2019 16:47:14 -0600 [thread overview]
Message-ID: <20190220224714.16303-4-dharmik.thakkar@arm.com> (raw)
In-Reply-To: <20190220224714.16303-1-dharmik.thakkar@arm.com>
This patch replaces macro with log-level based approach to print debug
information. Need to set timer log type to debug using the following
eal parameter: --log-level=timer,8
Change-Id: I31e660e31b556ccade314a948226f0f076231a15
Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* Add Reviewed-by tag
---
test/test/test_timer_racecond.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/test/test/test_timer_racecond.c b/test/test/test_timer_racecond.c
index d29048eaf1bf..5ac248b2d90b 100644
--- a/test/test/test_timer_racecond.c
+++ b/test/test/test_timer_racecond.c
@@ -44,8 +44,6 @@
#include <rte_malloc.h>
#include <rte_pause.h>
-#undef TEST_TIMER_RACECOND_VERBOSE
-
#ifdef RTE_EXEC_ENV_LINUXAPP
#define usec_delay(us) usleep(us)
#else
@@ -70,13 +68,12 @@ timer_cb(struct rte_timer *tim, void *arg __rte_unused)
{
/* Simulate slow callback function, 100 us. */
rte_delay_us(100);
-
-#ifdef TEST_TIMER_RACECOND_VERBOSE
- if (tim == &timer[0])
- printf("------------------------------------------------\n");
- printf("timer_cb: core %u timer %lu\n",
- rte_lcore_id(), tim - timer);
-#endif
+ if (rte_log_get_level(RTE_LOGTYPE_TIMER) == RTE_LOG_DEBUG) {
+ if (tim == &timer[0])
+ printf("------------------------------------------------\n");
+ printf("%s: core %u timer %lu\n", __func__,
+ rte_lcore_id(), tim - timer);
+ }
(void)reload_timer(tim);
}
@@ -96,10 +93,10 @@ reload_timer(struct rte_timer *tim)
ret = rte_timer_reset(tim, ticks, PERIODICAL, master, timer_cb, NULL);
if (ret != 0) {
-#ifdef TEST_TIMER_RACECOND_VERBOSE
- printf("- core %u failed to reset timer %lu (OK)\n",
- rte_lcore_id(), tim - timer);
-#endif
+ if (rte_log_get_level(RTE_LOGTYPE_TIMER) == RTE_LOG_DEBUG) {
+ printf("- core %u failed to reset timer %lu (OK)\n",
+ rte_lcore_id(), tim - timer);
+ }
RTE_PER_LCORE(n_reset_collisions) += 1;
}
return ret;
--
2.17.1
next prev parent reply other threads:[~2019-02-20 22:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 20:31 [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 3/3] test/timer: " Dharmik Thakkar
2019-01-11 16:30 ` [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level Ferruh Yigit
2019-02-20 22:47 ` [dpdk-dev] [PATCH v2 " Dharmik Thakkar
2019-02-20 22:47 ` [dpdk-dev] [PATCH v2 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 22:47 ` [dpdk-dev] [PATCH v2 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 22:47 ` Dharmik Thakkar [this message]
2019-02-20 23:00 ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Dharmik Thakkar
2019-02-20 23:00 ` [dpdk-dev] [PATCH v3 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 23:00 ` [dpdk-dev] [PATCH v3 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 23:00 ` [dpdk-dev] [PATCH v3 3/3] test/timer: " Dharmik Thakkar
2019-02-20 23:08 ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Stephen Hemminger
2019-02-26 23:05 ` Dharmik Thakkar
2019-02-26 23:02 ` [dpdk-dev] [PATCH v4 " Dharmik Thakkar
2019-02-26 23:02 ` [dpdk-dev] [PATCH v4 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-26 23:02 ` [dpdk-dev] [PATCH v4 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-26 23:02 ` [dpdk-dev] [PATCH v4 3/3] test/timer: " Dharmik Thakkar
2019-03-28 18:26 ` [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level Thomas Monjalon
2019-03-28 18:26 ` Thomas Monjalon
2019-03-28 18:35 ` Thomas Monjalon
2019-03-28 18:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220224714.16303-4-dharmik.thakkar@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=dev@dpdk.org \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).