From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id DB7DC2BB0 for ; Wed, 20 Feb 2019 23:48:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 353CD15AB; Wed, 20 Feb 2019 14:48:30 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F0AA83F719; Wed, 20 Feb 2019 14:48:29 -0800 (PST) From: Dharmik Thakkar To: Robert Sanford Cc: dev@dpdk.org, Dharmik Thakkar Date: Wed, 20 Feb 2019 16:47:14 -0600 Message-Id: <20190220224714.16303-4-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190220224714.16303-1-dharmik.thakkar@arm.com> References: <20181129203112.12222-1-dharmik.thakkar@arm.com> <20190220224714.16303-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v2 3/3] test/timer: enable unit test compilation always X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 22:48:31 -0000 This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=timer,8 Change-Id: I31e660e31b556ccade314a948226f0f076231a15 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Ferruh Yigit --- v2: * Add Reviewed-by tag --- test/test/test_timer_racecond.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/test/test/test_timer_racecond.c b/test/test/test_timer_racecond.c index d29048eaf1bf..5ac248b2d90b 100644 --- a/test/test/test_timer_racecond.c +++ b/test/test/test_timer_racecond.c @@ -44,8 +44,6 @@ #include #include -#undef TEST_TIMER_RACECOND_VERBOSE - #ifdef RTE_EXEC_ENV_LINUXAPP #define usec_delay(us) usleep(us) #else @@ -70,13 +68,12 @@ timer_cb(struct rte_timer *tim, void *arg __rte_unused) { /* Simulate slow callback function, 100 us. */ rte_delay_us(100); - -#ifdef TEST_TIMER_RACECOND_VERBOSE - if (tim == &timer[0]) - printf("------------------------------------------------\n"); - printf("timer_cb: core %u timer %lu\n", - rte_lcore_id(), tim - timer); -#endif + if (rte_log_get_level(RTE_LOGTYPE_TIMER) == RTE_LOG_DEBUG) { + if (tim == &timer[0]) + printf("------------------------------------------------\n"); + printf("%s: core %u timer %lu\n", __func__, + rte_lcore_id(), tim - timer); + } (void)reload_timer(tim); } @@ -96,10 +93,10 @@ reload_timer(struct rte_timer *tim) ret = rte_timer_reset(tim, ticks, PERIODICAL, master, timer_cb, NULL); if (ret != 0) { -#ifdef TEST_TIMER_RACECOND_VERBOSE - printf("- core %u failed to reset timer %lu (OK)\n", - rte_lcore_id(), tim - timer); -#endif + if (rte_log_get_level(RTE_LOGTYPE_TIMER) == RTE_LOG_DEBUG) { + printf("- core %u failed to reset timer %lu (OK)\n", + rte_lcore_id(), tim - timer); + } RTE_PER_LCORE(n_reset_collisions) += 1; } return ret; -- 2.17.1