From: Tiwei Bie <tiwei.bie@intel.com>
To: Dariusz Stojaczyk <darek.stojaczyk@gmail.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com,
Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: remove vhost-net requirements from generic vhost APIs
Date: Mon, 25 Feb 2019 12:54:39 +0800 [thread overview]
Message-ID: <20190225045438.GA31146@dpdk-tbie.sh.intel.com> (raw)
In-Reply-To: <20190224233555.31304-1-darek.stojaczyk@gmail.com>
On Mon, Feb 25, 2019 at 12:35:55AM +0100, Dariusz Stojaczyk wrote:
> From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
>
> The rte_vhost API to put data into virtqueues operates
> on mbufs and hence it is strictly vhost-net specific.
> External backends need to implement virtqueue handling
> from scratch and that's just not possible without APIs
> to get/set vring base addresses.
>
> Those relevant APIs are there, but they have a check that
> prevents them from working with any non-vhost-net device.
> This patch removes those checks.
>
> rte_vhost_get_log_base() is not necessarily needed for
> external backends, as other, higher level vhost APIs for
> live migration are available and could be used instead.
> We remove the extra check from it anyway for consistency.
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> lib/librte_vhost/vhost.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Tiwei
next prev parent reply other threads:[~2019-02-25 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 23:35 Dariusz Stojaczyk
2019-02-25 4:54 ` Tiwei Bie [this message]
2019-02-27 8:31 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225045438.GA31146@dpdk-tbie.sh.intel.com \
--to=tiwei.bie@intel.com \
--cc=darek.stojaczyk@gmail.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).