From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0014F29C6 for ; Mon, 25 Feb 2019 05:54:41 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2019 20:54:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,410,1544515200"; d="scan'208";a="149661575" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2019 20:54:39 -0800 Date: Mon, 25 Feb 2019 12:54:39 +0800 From: Tiwei Bie To: Dariusz Stojaczyk Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, Darek Stojaczyk Message-ID: <20190225045438.GA31146@dpdk-tbie.sh.intel.com> References: <20190224233555.31304-1-darek.stojaczyk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190224233555.31304-1-darek.stojaczyk@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: remove vhost-net requirements from generic vhost APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 04:54:42 -0000 On Mon, Feb 25, 2019 at 12:35:55AM +0100, Dariusz Stojaczyk wrote: > From: Darek Stojaczyk > > The rte_vhost API to put data into virtqueues operates > on mbufs and hence it is strictly vhost-net specific. > External backends need to implement virtqueue handling > from scratch and that's just not possible without APIs > to get/set vring base addresses. > > Those relevant APIs are there, but they have a check that > prevents them from working with any non-vhost-net device. > This patch removes those checks. > > rte_vhost_get_log_base() is not necessarily needed for > external backends, as other, higher level vhost APIs for > live migration are available and could be used instead. > We remove the extra check from it anyway for consistency. > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_vhost/vhost.c | 21 --------------------- > 1 file changed, 21 deletions(-) Reviewed-by: Tiwei Bie Thanks, Tiwei