DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring
@ 2019-02-22  8:13 Jiayu Hu
  2019-02-25  7:06 ` Tiwei Bie
  2019-03-17  6:38 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
  0 siblings, 2 replies; 12+ messages in thread
From: Jiayu Hu @ 2019-02-22  8:13 UTC (permalink / raw)
  To: dev; +Cc: tiwei.bie, maxime.coquelin, Jiayu Hu, stable

The VIRTIO_RING_F_EVENT_IDX feature of split ring might
be broken, as the value of signalled_used is unpredictable
after live migration or start up. This patch fixes it by
using signalled_used_valid.

In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX
implementation of split ring match kernel backend to suppress
more interrupts.

Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppression")
Cc: stable@dpdk.org

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
 lib/librte_vhost/vhost.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index fc31796..c4e5e34 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -633,16 +633,20 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq)
 	if (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {
 		uint16_t old = vq->signalled_used;
 		uint16_t new = vq->last_used_idx;
+		bool signalled_used_valid = vq->signalled_used_valid;
+
+		vq->signalled_used = new;
+		vq->signalled_used_valid = true;
 
 		VHOST_LOG_DEBUG(VHOST_DATA, "%s: used_event_idx=%d, old=%d, new=%d\n",
 			__func__,
 			vhost_used_event(vq),
 			old, new);
-		if (vhost_need_event(vhost_used_event(vq), new, old)
-			&& (vq->callfd >= 0)) {
-			vq->signalled_used = vq->last_used_idx;
+
+		if ((vhost_need_event(vhost_used_event(vq), new, old) &&
+					(vq->callfd >= 0)) ||
+				unlikely(!signalled_used_valid))
 			eventfd_write(vq->callfd, (eventfd_t) 1);
-		}
 	} else {
 		/* Kick the guest if necessary. */
 		if (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT)
-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-03-20  7:36 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22  8:13 [dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring Jiayu Hu
2019-02-25  7:06 ` Tiwei Bie
2019-02-27  5:38   ` Hu, Jiayu
2019-02-27 10:55     ` Tiwei Bie
2019-03-17  6:38 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2019-03-17  6:38   ` Jiayu Hu
2019-03-20  0:45   ` Wang, Yinan
2019-03-20  0:45     ` Wang, Yinan
2019-03-20  4:56   ` Tiwei Bie
2019-03-20  4:56     ` Tiwei Bie
2019-03-20  7:36   ` Maxime Coquelin
2019-03-20  7:36     ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).