Re: [dpdk-dev] [PATCH] net/nfb: new netcope driver

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 26 Feb 2019 13:57:04 +0100
Rastislav Cernay <cernay@netcope.com> wrote:

> +static void
> +nfb_eth_dev_info(struct rte_eth_dev *dev,
> +	struct rte_eth_dev_info *dev_info)
> +{
> +	dev_info->if_index = 0;
> +	dev_info->max_mac_addrs = 1;
> +	dev_info->max_rx_pktlen = (uint32_t)-1;
> +	dev_info->max_rx_queues = dev->data->nb_rx_queues;
> +	dev_info->max_tx_queues = dev->data->nb_tx_queues;
> +	dev_info->min_rx_bufsize = 0;
> +	dev_info->speed_capa = ETH_LINK_SPEED_100G;
> +}

Minor nit, you don't need to zero entries here, the calling
code (in rte_eth_dev_info_get) already does a memset.

+static int
+nfb_eth_link_update(struct rte_eth_dev *dev,
+	int wait_to_complete __rte_unused)
+{
+	uint16_t i;
+	struct rte_eth_link link;
+	memset(&link, 0, sizeof(link));
+
+	struct pmd_internals *internals = (struct pmd_internals *)
+		dev->data->dev_private;

Since dev_private is a void * cast is unnecessary


+	struct nc_rxmac_status status;
+	status.speed = MAC_SPEED_UNKNOWN;
+
+	link.link_speed = ETH_SPEED_NUM_NONE;
+	link.link_status = ETH_LINK_DOWN;
+	link.link_duplex = ETH_LINK_FULL_DUPLEX;
+	link.link_autoneg = ETH_LINK_SPEED;

Don't mix declarations with code.

You can use C99 structure initialization to avoid memset here.