From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory
Date: Tue, 26 Feb 2019 11:24:28 +0000 [thread overview]
Message-ID: <20190226112427.GA284928@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <6358435.8ZjemOinAO@xps>
On Tue, Feb 26, 2019 at 10:14:08AM +0100, Thomas Monjalon wrote:
> 19/02/2019 15:53, Bruce Richardson:
> > Move app to "app" directory and enable with meson build.
> >
> > CC: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > MAINTAINERS | 2 +-
> > app/Makefile | 1 +
> > {test => app}/cmdline_test/Makefile | 0
> > {test => app}/cmdline_test/cmdline_test.c | 0
> > {test => app}/cmdline_test/cmdline_test.h | 0
> > {test => app}/cmdline_test/cmdline_test.py | 0
> > {test => app}/cmdline_test/cmdline_test_data.py | 0
> > {test => app}/cmdline_test/commands.c | 0
>
> Sorry, I didn't realize before,
> other test apps directories are named test-*.
> Shouldn't we name this one test-cmdline?
>
Looking into it now, changing the directory name is easy enough, however
the final binary produced is also called cmdline_test - should it be
changed too? Changing it would be a bit more invasive, and would be
user-visible (perhaps just to test suites), but would lead to more
consistency.
NOTE: this only applies to the "make" build, since the meson build uses the
directory name as the binary name, so it's already consistent. There is no
user visible change here, since the app wasn't available from meson builds
before.
My recommendation is therefore to rename the directory only, and leave the
binary name the same for make builds, given that when we switch completely
over to meson it will be consistent at that point.
Thoughts, Thomas?
/Bruce
next prev parent reply other threads:[~2019-02-26 11:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:26 [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 2/4] test/test-acl: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 3/4] test/test-pipeline: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder Bruce Richardson
2019-01-25 20:30 ` [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-29 11:40 ` Thomas Monjalon
2019-01-29 11:52 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 0/5] " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 9:14 ` Thomas Monjalon
2019-02-26 10:00 ` Bruce Richardson
2019-02-26 11:24 ` Bruce Richardson [this message]
2019-02-26 12:20 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 2/5] test/test-acl: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 3/5] test/test-pipeline: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-20 9:35 ` Ananyev, Konstantin
2019-02-20 9:39 ` Bruce Richardson
2019-02-20 9:42 ` Ananyev, Konstantin
2019-02-20 10:35 ` Thomas Monjalon
2019-02-25 16:22 ` Ananyev, Konstantin
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 5/5] test/test: move to app folder Bruce Richardson
2019-02-20 11:47 ` [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir Ferruh Yigit
2019-02-25 15:34 ` Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 2/5] test/test-acl: " Bruce Richardson
2019-02-26 12:27 ` Ananyev, Konstantin
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 3/5] test/test-pipeline: " Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 5/5] test/test: move to app folder Bruce Richardson
2019-02-26 14:40 ` [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226112427.GA284928@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).