From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4DA1E1E2B
 for <dev@dpdk.org>; Tue, 26 Feb 2019 15:26:27 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Feb 2019 06:26:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,415,1544515200"; d="scan'208";a="127376538"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36])
 by fmsmga008.fm.intel.com with SMTP; 26 Feb 2019 06:26:24 -0800
Received: by  (sSMTP sendmail emulation); Tue, 26 Feb 2019 14:26:23 +0000
Date: Tue, 26 Feb 2019 14:26:23 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org
Message-ID: <20190226142623.GB77832@bricha3-MOBL.ger.corp.intel.com>
References: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1551190689-139613-1-git-send-email-andrius.sirvys@intel.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Subject: Re: [dpdk-dev] [PATCH] build: add meson support for icc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2019 14:26:27 -0000

On Tue, Feb 26, 2019 at 02:18:09PM +0000, Andrius Sirvys wrote:
> When building with mason, checks if the compiler is icc. If they match,
> the warning_flags are changed to ensure icc compilation is successful.
> 
> Disabled error 3656: "variable may be used before its value is set"
> in librte_telemetry, bnx2x, ixgbe and sfc as they were false positives.
> 
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Looks ok to me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

If you are up for it, could you also do an additional patch to add an icc
build to "test-meson-builds.sh" if icc is found on the system?