From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id C21A627D for ; Wed, 27 Feb 2019 00:03:07 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A35A169E; Tue, 26 Feb 2019 15:03:07 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCD603F738; Tue, 26 Feb 2019 15:03:06 -0800 (PST) From: Dharmik Thakkar To: Byron Marohn , Pablo de Lara Guarch Cc: dev@dpdk.org, Dharmik Thakkar Date: Tue, 26 Feb 2019 17:02:28 -0600 Message-Id: <20190226230229.25450-3-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190226230229.25450-1-dharmik.thakkar@arm.com> References: <20190220230023.17029-1-dharmik.thakkar@arm.com> <20190226230229.25450-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v4 2/3] test/efd: enable unit test compilation always X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 23:03:08 -0000 This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-level=test.efd:debug Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Ferruh Yigit --- v4: * change to dynamic logging (Stephen Hemminger) --- v3: * Resolve coding style issues --- v2: * Add Reviewed-by tag --- test/test/test_efd.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/test/test/test_efd.c b/test/test/test_efd.c index ced091aab63d..93e8f1cbb8bd 100644 --- a/test/test/test_efd.c +++ b/test/test/test_efd.c @@ -31,31 +31,29 @@ struct flow_key { uint16_t port_dst; uint8_t proto; } __attribute__((packed)); + +int efd_logtype_test; + +RTE_INIT(test_efd_init_log) +{ + efd_logtype_test = rte_log_register("test.efd"); +} + /* * Print out result of unit test efd operation. */ -#if defined(UNIT_TEST_EFD_VERBOSE) - static void print_key_info(const char *msg, const struct flow_key *key, efd_value_t val) { const uint8_t *p = (const uint8_t *) key; unsigned int i; - printf("%s key:0x", msg); + rte_log(RTE_LOG_DEBUG, efd_logtype_test, "%s key:0x", msg); for (i = 0; i < sizeof(struct flow_key); i++) - printf("%02X", p[i]); + rte_log(RTE_LOG_DEBUG, efd_logtype_test, "%02X", p[i]); - printf(" @ val %d\n", val); + rte_log(RTE_LOG_DEBUG, efd_logtype_test, " @ val %d\n", val); } -#else - -static void print_key_info(__attribute__((unused)) const char *msg, - __attribute__((unused)) const struct flow_key *key, - __attribute__((unused)) efd_value_t val) -{ -} -#endif /* Keys used by unit test functions */ static struct flow_key keys[5] = { -- 2.17.1