From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 09CC4378B for ; Wed, 27 Feb 2019 10:47:50 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2019 01:47:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,419,1544515200"; d="scan'208";a="142017819" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.36]) by orsmga001.jf.intel.com with SMTP; 27 Feb 2019 01:47:47 -0800 Received: by (sSMTP sendmail emulation); Wed, 27 Feb 2019 09:47:46 +0000 Date: Wed, 27 Feb 2019 09:47:46 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Luca Boccassi , dev@dpdk.org Message-ID: <20190227094746.GA91912@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-6-luca.boccassi@gmail.com> <2422048.eyOlUYzsqs@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2422048.eyOlUYzsqs@xps> User-Agent: Mutt/1.11.2 (2019-01-07) Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 09:47:51 -0000 On Wed, Feb 27, 2019 at 09:33:12AM +0100, Thomas Monjalon wrote: > 26/02/2019 18:49, Luca Boccassi: > > On Tue, 2019-02-26 at 17:46 +0000, luca.boccassi@gmail.com wrote: > > > From: Luca Boccassi > > > > > > pcap has historically shipped a custom pcap-config binary tool which > > > does the job of pkg-config. It was never compatible with cross > > > compilation. > > > Meson uses it when using dependency(), which then means cross > > > compilation fails. > > > Set pcap-config to empty in the meson cross compilation files so > > > that Meson will not use it, and add a fallback in case > > > dependency() fails. > > > libpcap 1.9.0 finally ships a pkg-config file so everything will > > > work out of the box in the future. > > > > > > Signed-off-by: Luca Boccassi > > > --- > > > v8: added back pcap change separately. Tested with bootlin > > > cross-compilation toolchain, everything seems to work. > > > > I had some time to invest so I added back this change, in a way that > > works with cross compilation too. Given the series wasn't merged yet > > and there was a conflict I've done a v8 rather than a single separate > > patch, but it's independent from the rest. > > > > More testing is of course welcome! > > I still see the same error when cross-compiling: > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > Can patches 1-5 be merged anyway, leaving 6 for later? /Bruce