[dpdk-dev] [PATCH 0/2] dpdk-draft-windows X710-DA2 compatibility

[dpdk-dev] [PATCH 0/2] dpdk-draft-windows X710-DA2 compatibility

[Martin Birks]

An effort was made to get dpdk working on Windows Server 2019 with an X710-DA2 card. This required the minimal changes as in the patches

Martin Birks (2):
  kernel/windows: Added support for X710-DA2 to inf file.
  kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that
    SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc:
    change the Windows UIO driver's default security descriptor to admin
    only") Cc: haramakr@microsoft.com

 kernel/windows/netuio/netuio.inf   | 2 ++
 kernel/windows/netuio/netuio_dev.c | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.18.0.windows.1

[dpdk-dev] [PATCH 1/2] kernel/windows: Added support for X710-DA2 to inf file.

[Martin Birks]

Signed-off-by: Martin Birks <martin.birks@activfinancial.com>
---
 kernel/windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/windows/netuio/netuio.inf b/kernel/windows/netuio/netuio.inf
index 0453b371a..cf7c71345 100644
--- a/kernel/windows/netuio/netuio.inf
+++ b/kernel/windows/netuio/netuio.inf
@@ -55,6 +55,7 @@ DriverVer=
 %F158B.netuio.Description%=netuio_Device, PCI\VEN_8086&DEV_158B   ; I40E_DEV_ID_25G_SFP28
 %F37D0.netuio.Description%=netuio_Device, PCI\VEN_8086&DEV_37D0
 %F153B.netuio.Description%=netuio_Device, PCI\VEN_8086&DEV_153B
+%F1572.netuio.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 
 [netuio_Device.NT]
 CopyFiles=Drivers_Dir
@@ -114,5 +115,6 @@ F158A.netuio.Description = "DPDK netUIO for Intel(R) Ethernet Network Adapter XX
 F158B.netuio.Description = "DPDK netUIO for Intel(R) Ethernet Network Adapter XXV710-DA1"
 F37D0.netuio.Description = "DPDK netUIO for Intel(R) Ethernet Connection X722"
 F153B.netuio.Description = "DPDK netUIO for Intel(R) Ethernet Connection I217-V"
+F1572.netuio.Description = "DPDK netUIO for Intel(R) Ethernet Network Adapter X710-DA2"
 netuio.DeviceDesc = "netuio Device"
 netuio.SVCDESC = "netuio Service"
-- 
2.18.0.windows.1

[dpdk-dev] [PATCH 2/2] kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc: change the Windows UIO driver's default security descriptor to admin only") Cc: haramakr@microsoft.com

[Martin Birks]

Signed-off-by: Martin Birks <martin.birks@activfinancial.com>
---
 kernel/windows/netuio/netuio_dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c
index f5d41cb65..1f01e2324 100644
--- a/kernel/windows/netuio/netuio_dev.c
+++ b/kernel/windows/netuio/netuio_dev.c
@@ -33,6 +33,9 @@ netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit)
 
     PAGED_CODE();
 
+    // Need to set a name for the device for SDDL string to work
+    WdfDeviceInitSetCharacteristics(DeviceInit, FILE_AUTOGENERATED_DEVICE_NAME, TRUE);
+
     // Ensure that only administrators can access our device object.
     status = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);
 
-- 
2.18.0.windows.1

[dpdk-dev] [PATCH 0/2] *** dpdk-draft-windows X710-DA2 compatibility ***

[Martin Birks]

*** An effort was made to get dpdk working on Windows Server 2019 with an X710-DA2 card. This required the minimal changes as in the patches. ***

Martin Birks (2):
  kernel/windows: Added support for X710-DA2 to inf file.
  kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that
    SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc:
    change the Windows UIO driver's default security descriptor to admin
    only") Cc: haramakr@microsoft.com

 kernel/windows/netuio/netuio.inf   | 2 ++
 kernel/windows/netuio/netuio_dev.c | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.18.0.windows.1

[dpdk-dev] [PATCH 2/2] kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc: change the Windows UIO driver's default security descriptor to admin only") Cc: haramakr@microsoft.com

[Martin Birks]

---
 kernel/windows/netuio/netuio_dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c
index f5d41cb65..1f01e2324 100644
--- a/kernel/windows/netuio/netuio_dev.c
+++ b/kernel/windows/netuio/netuio_dev.c
@@ -33,6 +33,9 @@ netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit)
 
     PAGED_CODE();
 
+    // Need to set a name for the device for SDDL string to work
+    WdfDeviceInitSetCharacteristics(DeviceInit, FILE_AUTOGENERATED_DEVICE_NAME, TRUE);
+
     // Ensure that only administrators can access our device object.
     status = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);
 
-- 
2.18.0.windows.1