* [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info
@ 2019-03-01 7:16 Pavan Nikhilesh Bhagavatula
2019-03-01 7:16 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence Pavan Nikhilesh Bhagavatula
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-03-01 7:16 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, harry.van.haaren
Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Some eventdevs support configuring max events to be -1 (open system).
Check eventdev and event port configuration with eventdev info before
configuring them.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++++++
examples/eventdev_pipeline/pipeline_worker_tx.c | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/examples/eventdev_pipeline/pipeline_worker_generic.c b/examples/eventdev_pipeline/pipeline_worker_generic.c
index 169064949..766c8e958 100644
--- a/examples/eventdev_pipeline/pipeline_worker_generic.c
+++ b/examples/eventdev_pipeline/pipeline_worker_generic.c
@@ -169,6 +169,8 @@ setup_eventdev_generic(struct worker_data *worker_data)
wkr_p_conf.disable_implicit_release = disable_implicit_release;
+ if (dev_info.max_num_events < config.nb_events_limit)
+ config.nb_events_limit = dev_info.max_num_events;
if (dev_info.max_event_port_dequeue_depth <
config.nb_event_port_dequeue_depth)
config.nb_event_port_dequeue_depth =
@@ -227,6 +229,8 @@ setup_eventdev_generic(struct worker_data *worker_data)
}
cdata.tx_queue_id = i;
+ if (wkr_p_conf.new_event_threshold > config.nb_events_limit)
+ wkr_p_conf.new_event_threshold = config.nb_events_limit;
if (wkr_p_conf.dequeue_depth > config.nb_event_port_dequeue_depth)
wkr_p_conf.dequeue_depth = config.nb_event_port_dequeue_depth;
if (wkr_p_conf.enqueue_depth > config.nb_event_port_enqueue_depth)
@@ -284,6 +288,8 @@ init_adapters(uint16_t nb_ports)
.new_event_threshold = 4096,
};
+ if (adptr_p_conf.new_event_threshold > dev_info.max_num_events)
+ adptr_p_conf.new_event_threshold = dev_info.max_num_events;
if (adptr_p_conf.dequeue_depth > dev_info.max_event_port_dequeue_depth)
adptr_p_conf.dequeue_depth =
dev_info.max_event_port_dequeue_depth;
diff --git a/examples/eventdev_pipeline/pipeline_worker_tx.c b/examples/eventdev_pipeline/pipeline_worker_tx.c
index 85eb075fc..8961cd656 100644
--- a/examples/eventdev_pipeline/pipeline_worker_tx.c
+++ b/examples/eventdev_pipeline/pipeline_worker_tx.c
@@ -465,6 +465,8 @@ setup_eventdev_worker_tx_enq(struct worker_data *worker_data)
ret = rte_event_dev_info_get(dev_id, &dev_info);
printf("\tEventdev %d: %s\n", dev_id, dev_info.driver_name);
+ if (dev_info.max_num_events < config.nb_events_limit)
+ config.nb_events_limit = dev_info.max_num_events;
if (dev_info.max_event_port_dequeue_depth <
config.nb_event_port_dequeue_depth)
config.nb_event_port_dequeue_depth =
@@ -528,6 +530,8 @@ setup_eventdev_worker_tx_enq(struct worker_data *worker_data)
}
printf("\n");
+ if (wkr_p_conf.new_event_threshold > config.nb_events_limit)
+ wkr_p_conf.new_event_threshold = config.nb_events_limit;
if (wkr_p_conf.dequeue_depth > config.nb_event_port_dequeue_depth)
wkr_p_conf.dequeue_depth = config.nb_event_port_dequeue_depth;
if (wkr_p_conf.enqueue_depth > config.nb_event_port_enqueue_depth)
@@ -617,6 +621,8 @@ init_adapters(uint16_t nb_ports)
.new_event_threshold = 4096,
};
+ if (adptr_p_conf.new_event_threshold > dev_info.max_num_events)
+ adptr_p_conf.new_event_threshold = dev_info.max_num_events;
if (adptr_p_conf.dequeue_depth > dev_info.max_event_port_dequeue_depth)
adptr_p_conf.dequeue_depth =
dev_info.max_event_port_dequeue_depth;
--
2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence
2019-03-01 7:16 [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Pavan Nikhilesh Bhagavatula
@ 2019-03-01 7:16 ` Pavan Nikhilesh Bhagavatula
2019-03-11 9:57 ` Van Haaren, Harry
2019-03-01 7:16 ` [dpdk-dev] [PATCH 3/3] app/eventdev: " Pavan Nikhilesh Bhagavatula
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-03-01 7:16 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, harry.van.haaren
Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Stop eventdev before closing it.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
examples/eventdev_pipeline/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c
index 92e08bc0c..2ad7d24e2 100644
--- a/examples/eventdev_pipeline/main.c
+++ b/examples/eventdev_pipeline/main.c
@@ -421,6 +421,7 @@ signal_handler(int signum)
rte_eth_dev_close(portid);
}
+ rte_event_dev_stop(0);
rte_event_dev_close(0);
}
if (signum == SIGTSTP)
--
2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence
2019-03-01 7:16 [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Pavan Nikhilesh Bhagavatula
2019-03-01 7:16 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence Pavan Nikhilesh Bhagavatula
@ 2019-03-01 7:16 ` Pavan Nikhilesh Bhagavatula
2019-03-11 9:58 ` Van Haaren, Harry
2019-03-08 18:25 ` [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Jerin Jacob Kollanukkaran
2019-03-11 9:57 ` Van Haaren, Harry
3 siblings, 1 reply; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2019-03-01 7:16 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, harry.van.haaren
Cc: dev, Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Stop eventdev before closing it.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-eventdev/test_pipeline_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 5db3ffde1..1e525643d 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -396,6 +396,7 @@ pipeline_eventdev_destroy(struct evt_test *test, struct evt_options *opt)
{
RTE_SET_USED(test);
+ rte_event_dev_stop(opt->dev_id);
rte_event_dev_close(opt->dev_id);
}
--
2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info
2019-03-01 7:16 [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Pavan Nikhilesh Bhagavatula
2019-03-01 7:16 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence Pavan Nikhilesh Bhagavatula
2019-03-01 7:16 ` [dpdk-dev] [PATCH 3/3] app/eventdev: " Pavan Nikhilesh Bhagavatula
@ 2019-03-08 18:25 ` Jerin Jacob Kollanukkaran
2019-03-11 9:57 ` Van Haaren, Harry
3 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-08 18:25 UTC (permalink / raw)
To: harry.van.haaren, Pavan Nikhilesh Bhagavatula; +Cc: dev
On Fri, 2019-03-01 at 07:16 +0000, Pavan Nikhilesh Bhagavatula wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Some eventdevs support configuring max events to be -1 (open system).
> Check eventdev and event port configuration with eventdev info before
> configuring them.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++++++
> examples/eventdev_pipeline/pipeline_worker_tx.c | 6 ++++++
Hi Harry,
Any comments on this patch series as examples/eventdev_pipeline
maintainer?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info
2019-03-01 7:16 [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Pavan Nikhilesh Bhagavatula
` (2 preceding siblings ...)
2019-03-08 18:25 ` [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Jerin Jacob Kollanukkaran
@ 2019-03-11 9:57 ` Van Haaren, Harry
3 siblings, 0 replies; 8+ messages in thread
From: Van Haaren, Harry @ 2019-03-11 9:57 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran; +Cc: dev
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> Sent: Friday, March 1, 2019 7:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max
> events based on dev info
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Some eventdevs support configuring max events to be -1 (open system).
> Check eventdev and event port configuration with eventdev info before
> configuring them.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Makes sense to error check these, and set to max on open systems, thanks.
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence
2019-03-01 7:16 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence Pavan Nikhilesh Bhagavatula
@ 2019-03-11 9:57 ` Van Haaren, Harry
0 siblings, 0 replies; 8+ messages in thread
From: Van Haaren, Harry @ 2019-03-11 9:57 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran; +Cc: dev
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> Sent: Friday, March 1, 2019 7:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper
> teardown sequence
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Stop eventdev before closing it.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence
2019-03-01 7:16 ` [dpdk-dev] [PATCH 3/3] app/eventdev: " Pavan Nikhilesh Bhagavatula
@ 2019-03-11 9:58 ` Van Haaren, Harry
2019-03-11 15:12 ` Jerin Jacob Kollanukkaran
0 siblings, 1 reply; 8+ messages in thread
From: Van Haaren, Harry @ 2019-03-11 9:58 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran; +Cc: dev
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> Sent: Friday, March 1, 2019 7:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown
> sequence
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Stop eventdev before closing it.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence
2019-03-11 9:58 ` Van Haaren, Harry
@ 2019-03-11 15:12 ` Jerin Jacob Kollanukkaran
0 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-11 15:12 UTC (permalink / raw)
To: harry.van.haaren, Pavan Nikhilesh Bhagavatula; +Cc: dev
On Mon, 2019-03-11 at 09:58 +0000, Van Haaren, Harry wrote:
> -------------------------------------------------------------------
> ---
> > -----Original Message-----
> > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> > Sent: Friday, March 1, 2019 7:17 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren,
> > Harry
> > <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <
> > pbhagavatula@marvell.com>
> > Subject: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper
> > teardown
> > sequence
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Stop eventdev before closing it.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Series applied to dpdk-next-eventdev/master. Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-11 15:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 7:16 [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Pavan Nikhilesh Bhagavatula
2019-03-01 7:16 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence Pavan Nikhilesh Bhagavatula
2019-03-11 9:57 ` Van Haaren, Harry
2019-03-01 7:16 ` [dpdk-dev] [PATCH 3/3] app/eventdev: " Pavan Nikhilesh Bhagavatula
2019-03-11 9:58 ` Van Haaren, Harry
2019-03-11 15:12 ` Jerin Jacob Kollanukkaran
2019-03-08 18:25 ` [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info Jerin Jacob Kollanukkaran
2019-03-11 9:57 ` Van Haaren, Harry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).