From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
 [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 5B3BB2C38
 for <dev@dpdk.org>; Fri,  1 Mar 2019 19:39:49 +0100 (CET)
Received: by mail-pg1-f195.google.com with SMTP id y4so11805019pgc.12
 for <dev@dpdk.org>; Fri, 01 Mar 2019 10:39:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jPaJWhzjDTzcGgD14mbqvr4DrNfLNF5xUA/x/5pMH/4=;
 b=T2GUCVwrVs2jUooBRU89XJdJBVYhr1hNe5I++Um+ed0DDu/TccidBHROhNwXrjLOEz
 HNH+OLJCKH/H/If0UF/JPdwyOeck3nT/WcT1o0hYu765HmwT2cJkh0ah3UeHXj1xYlAZ
 8D+5OhrNeJn74mmrHBhiv657OV5nUb44jbq0rvCsNE+7xZ75T6EjqM2YLEURhSYGLunV
 h9f78QtafeHsxHfNkRqGuyRNbEI4KB/5eIvnHpPVzoOf8YZzEFnsfg/TaVSTKEWlvzeD
 XiDNz2cOTn1rVsQCNcPssV37vrVC52ewH2bb2SOWwc/glfPOXe5qIxYxoeRrreQFdZ3q
 a0fw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jPaJWhzjDTzcGgD14mbqvr4DrNfLNF5xUA/x/5pMH/4=;
 b=h0Gk8C4fokdH+CdD5zG1LjBjTwet41RoAzhY2m36ZJXeXrHiBesTGKKUdyLRcU0qvn
 TewIdx9gXY0WL719SasCNz0TO0RoCpysanm0j7rWGikpw1uYKIwp7IxpddzxSo7jqMRd
 xzm9lzLrCSLNVuKF3OEufFCMkjfips+fpFVeSiRKtfSO3K4d9wHxZp9XOpnWvlnDkQDE
 RE6CvbvpN1A1P3C4P8dXwIaQL/yF5lgW1nbWq7I8z0T+vtanL6UwxB9ZQtmSys4zr4Ve
 fUfzST+bKaZX5ILj8tRP90XOPXtTOlBOJB0f/9hPxm66eMJLj59FQWoOni+kcxvQUbeo
 i/sw==
X-Gm-Message-State: APjAAAWkEO/Olh8l29ecbPbLT4bFz11fCoX6+wdahpQKIU85AkhgGFQO
 TMciNyLeT0XlOvhUR4ZjH+uPsA==
X-Google-Smtp-Source: APXvYqyVB5a3rm3IkQul5BKZFNQBvvhVfpmVJ+k+5ze8wu39z9YGlD+KLE7mJ7FwcIyMSbNa7FxSHA==
X-Received: by 2002:a62:388a:: with SMTP id f132mr6981692pfa.150.1551465588512; 
 Fri, 01 Mar 2019 10:39:48 -0800 (PST)
Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com.
 [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id n74sm42173206pfb.188.2019.03.01.10.39.48
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 01 Mar 2019 10:39:48 -0800 (PST)
Date: Fri, 1 Mar 2019 10:39:46 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org
Message-ID: <20190301103946.2f7d8398@shemminger-XPS-13-9360>
In-Reply-To: <20190301124613.66527-1-qiming.yang@intel.com>
References: <20190301124613.66527-1-qiming.yang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 18:39:49 -0000

On Fri,  1 Mar 2019 20:46:12 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

>  static int
> +ice_parse_pkg_path_handler(__rte_unused const char *key,
> +			  const char *value,
> +			  void *opaque)
> +{
> +	struct ice_adapter *ad;
> +
> +	ad = (struct ice_adapter *)opaque;

Minor language nitpick:
Explicit cast of void * pointer is not necessary in C.