From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 88003374C for ; Fri, 1 Mar 2019 19:50:17 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id m10so11872421plt.10 for ; Fri, 01 Mar 2019 10:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t1vm6dXqbnuc9zgSi6AV0BWqikOLtmRRrtjpv5HR9ds=; b=YfbCCdSuLJK9TNYCn/gk7p35up6vRKLOMGE+4HW7MbBIa8fxbohRjgA6zFQfRtk86w iIFPvDevx+HQtE/okTn2rx6NNa3A9d2vQ/3s7ttPda8cBq9qp6UC8GCuT6pehqP9Hd4m Ly/ybo+dpknY660ZeRP0O9PjnJOHitlYuv1Ky3LE108pXxjHq1Y7wmA68ZYhvI76c7v7 C8guN50jp0pmE6+CS2XKPgLMtme3X+PD1F948jwE72D4HM9yb2sOgGXp+BbdhqFmYPuV mgXc4Y9mHCueSkkNytOpp3saEdyrA2TeiKVslsmxJp2ecmledl5MQDlg6vEQFfJplWbo cC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t1vm6dXqbnuc9zgSi6AV0BWqikOLtmRRrtjpv5HR9ds=; b=mbTjxeWJaVepOx4Mrgw2ZWyBOhMYUu1Ajii+CTNvbzjxSJLem+2ihdkwUI2voFOL/X uOkpsMm2pA/BG3/N1bYu9IfMdr/d7NwFL/v67aYc6AeJIeGL81jkmINUIF/n1s0Qhu3B 7rbB6QlcJJ+QWMaJqzASjwfXUQJrN80fUor/0F3sFO7ghblwZ/dhQPOMQq9jGZz/SqRF lxsJ3STn/sy4PIr3/Jh348bkn+v7WNUS4BXxU3/o8PgyrAR3PpUTOp5Mtz2rkuExyycp 83JA6uOOaC2cau3HRQVi00vgjIFBC7PMfJubbuXVMqtAm2/cY66wAcfowrMLdrc9Qb5B DRDg== X-Gm-Message-State: APjAAAVimmw00jfUthC2JYqTeVp4YP913SazitZeVX2ELCELj0Bg0oNM EoEfKqu/3Bv3wKhcDuUO5ChhlhfhDrU= X-Google-Smtp-Source: APXvYqzVPh61rkqvSD6/Y37qZlatabPELpGQSmlnVCJepUnCc3XOHTc5tTvRbwaSeHbh5wbZGv4AvQ== X-Received: by 2002:a17:902:bcc7:: with SMTP id o7mr7027611pls.89.1551466216727; Fri, 01 Mar 2019 10:50:16 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o85sm49036024pfi.105.2019.03.01.10.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 10:50:16 -0800 (PST) Date: Fri, 1 Mar 2019 10:50:14 -0800 From: Stephen Hemminger To: Rastislav Cernay Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20190301105014.17cffa3f@shemminger-XPS-13-9360> In-Reply-To: <1551451054-111249-1-git-send-email-cernay@netcope.com> References: <1551185824-5501-2-git-send-email-cernay@netcope.com> <1551451054-111249-1-git-send-email-cernay@netcope.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 18:50:18 -0000 On Fri, 1 Mar 2019 15:37:34 +0100 Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay > --- Please fix these obvious style issues from checkpatches ERROR:SPACING: space required before the open brace '{' #934: FILE: drivers/net/nfb/nfb_ethdev.c:380: + if (!is_valid_assigned_ether_addr(mac_addr)){ WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon #935: FILE: drivers/net/nfb/nfb_ethdev.c:381: + return -EINVAL;;