From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 075E73256; Fri, 1 Mar 2019 18:08:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6490CACA8; Fri, 1 Mar 2019 17:08:09 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF4095D707; Fri, 1 Mar 2019 17:08:08 +0000 (UTC) From: Michael Santana To: dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson , Van Haaren Harry , ramirose@gmail.com, Thomas Monjalon Date: Fri, 1 Mar 2019 12:08:06 -0500 Message-Id: <20190301170806.3547-3-msantana@redhat.com> In-Reply-To: <20190301170806.3547-1-msantana@redhat.com> References: <20190214193547.30783-1-msantana@redhat.com> <20190301170806.3547-1-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 01 Mar 2019 17:08:09 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3 2/2] devtools: fix result of svg include check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 17:08:10 -0000 Fix trivial bug. In sh shell, 'foo = 1' is not the same as 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo as a command, rather than a simple variable assignment. Signed-off-by: Michael Santana Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") --- devtools/checkpatches.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index d3c0b309a..16b705384 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -73,7 +73,7 @@ check_forbidden_additions() { # -v RET_ON_FAIL=1 \ -v MESSAGE='Using explicit .svg extension instead of .*' \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \ - "$1" || res = 1 + "$1" || res=1 return $res } -- 2.20.1